From: Scott Wood <scottwood@freescale.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label
Date: Tue, 19 Jun 2012 16:52:56 -0500 [thread overview]
Message-ID: <4FE0F4B8.7020603@freescale.com> (raw)
In-Reply-To: <4FE013E3.6090907@weilnetz.de>
On 06/19/2012 12:53 AM, Stefan Weil wrote:
> Am 19.06.2012 04:31, schrieb Scott Wood:
>> If tci_out_label is called in the context of tcg_gen_code_search_pc, we
>> could be overwriting an already patched relocation with zero -- and not
>> repatch it because the set_label is past search_pc, causing a QEMU crash
>> when it tries to branch to a zero label.
>>
>> Not writing anything to the relocation area seems to be in line with what
>> other backends do from the couple I looked at (x86, ppc).
>
> Thanks, this might fix a crash which I have seen from time to time.
> I'll run tests as soon as possible.
>
> Could you please also look at the other backends?
>
> I saw from git history that ppc once had the same bug.
> The sparc backend (and maybe others) might still have it.
SPARC looks wrong; the others look OK as far as I can tell from a quick
glance, without being familiar with all of the architectures.
-Scott
next prev parent reply other threads:[~2012-06-19 21:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 2:31 [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label Scott Wood
2012-06-19 5:53 ` Stefan Weil
2012-06-19 18:02 ` Blue Swirl
2012-06-20 15:48 ` Stefan Weil
2012-06-19 21:52 ` Scott Wood [this message]
2012-06-19 22:11 ` Peter Maydell
2012-06-24 12:27 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE0F4B8.7020603@freescale.com \
--to=scottwood@freescale.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.