From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 02/10] ath9k: Add definitions and structures to support WoW
Date: Wed, 20 Jun 2012 10:35:27 +0530 [thread overview]
Message-ID: <4FE15A17.9040804@qca.qualcomm.com> (raw)
In-Reply-To: <20120619173810.GA7191@vmraj-lnx.qca.qualcomm.com>
Hi Raj,
On Tuesday 19 June 2012 11:08 PM, Rajkumar Manoharan wrote:
> On Tue, Jun 19, 2012 at 09:17:22PM +0530, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> *add structures, macros and variables for WoW, so that the driver
>> can make use of it.
>> *maintain a list for user enabled patterns and masks
>> *track pattern slots for the hardware limitation on the
>> maximum number of patterns that can be stored.
>> *track interrupts enabled before WoW suspend, so
>> that can be reconfigured after resume
>> *have macros to parse user defined wow configurations to
>> hardware code
>>
>> Cc: Senthil Balasubramanian<senthilb@qca.qualcomm.com>
>> Cc: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>> Cc: vadivel at qca.qualcomm.com
>> Tested-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> Signed-off-by: Luis R. Rodriguez<mcgrof@qca.qualcomm.com>
>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath9k/ath9k.h | 20 ++++++++++++++++++++
>> drivers/net/wireless/ath/ath9k/hw.h | 21 +++++++++++++++++++++
>> 2 files changed, 41 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
>> index a8c0500..264c25b 100644
>> --- a/drivers/net/wireless/ath/ath9k/ath9k.h
>> +++ b/drivers/net/wireless/ath/ath9k/ath9k.h
>> @@ -505,6 +505,19 @@ static inline u16 ath9k_btcoex_aggr_limit(struct ath_softc *sc,
>> }
>> #endif /* CONFIG_ATH9K_BTCOEX_SUPPORT */
>>
>> +struct ath9k_wow_pattern {
>> + bool slot;
>> + u8 pattern_bytes[MAX_PATTERN_SIZE];
>> + u8 mask_bytes[MAX_PATTERN_SIZE];
>> + u32 pattern_len;
>> + struct list_head list;
>> +};
>> +
>> +struct ath9k_wow_info {
>> + u32 num_of_patterns;
>> + struct list_head wow_patterns;
>> +};
>> +
>> /********************/
>> /* LED Control */
>> /********************/
>> @@ -706,6 +719,13 @@ struct ath_softc {
>> struct ath_ant_comb ant_comb;
>> u8 ant_tx, ant_rx;
>> struct dfs_pattern_detector *dfs_detector;
>> +
>> +#ifdef CONFIG_PM_SLEEP
>> + bool wow_got_bmiss_intr;
>> + bool wow_sleep_proc_intr; /* in the middle of WoW sleep ? */
>> + u32 wow_intr_before_sleep;
>> + struct ath9k_wow_info wow_info;
>> +#endif
>> };
>>
>> void ath9k_tasklet(unsigned long data);
>> diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h
>> index 03d5909..d0e14a3 100644
>> --- a/drivers/net/wireless/ath/ath9k/hw.h
>> +++ b/drivers/net/wireless/ath/ath9k/hw.h
>> @@ -179,6 +179,24 @@
>> #define PAPRD_TABLE_SZ 24
>> #define PAPRD_IDEAL_AGC2_PWR_RANGE 0xe0
>>
>> +/* Wake on Wireless */
>> +
>> +#define MAX_PATTERN_SIZE 256
>> +#define MAX_PATTERN_MASK_SIZE 32
>> +#define MAX_NUM_PATTERN 8
>> +#define MAX_NUM_USER_PATTERN 6 /* deducting the disassociate and
>> + deauthenticate packets */
>> +
>> +/*
>> + * WoW trigger mapping to hardware code
>> + */
>> +
>> +#define AH_WOW_USER_PATTERN_EN BIT(0)
>> +#define AH_WOW_MAGIC_PATTERN_EN BIT(1)
>> +#define AH_WOW_LINK_CHANGE BIT(2)
>> +#define AH_WOW_BEACON_MISS BIT(3)
>> +#define AH_WOW_MAX_EVENTS 4
> Why do you need AH_WOW_MAX_EVENT? It looks like out of sync and also it is never be used.
i will correct this out in v2. also found few more unused stuff, will
correct it out. thanks for your review.
--
thanks,
shafi
WARNING: multiple messages have this Message-ID (diff)
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>,
Rodriguez Luis <rodrigue@qca.qualcomm.com>,
<ath9k-devel@lists.ath9k.org>,
Sujith Manoharan <c_manoha@qca.qualcomm.com>,
<vadivel@qca.qualcomm.com>, <rhu@qca.qualcomm.com>,
<aeolus@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH 02/10] ath9k: Add definitions and structures to support WoW
Date: Wed, 20 Jun 2012 10:35:27 +0530 [thread overview]
Message-ID: <4FE15A17.9040804@qca.qualcomm.com> (raw)
In-Reply-To: <20120619173810.GA7191@vmraj-lnx.qca.qualcomm.com>
Hi Raj,
On Tuesday 19 June 2012 11:08 PM, Rajkumar Manoharan wrote:
> On Tue, Jun 19, 2012 at 09:17:22PM +0530, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> *add structures, macros and variables for WoW, so that the driver
>> can make use of it.
>> *maintain a list for user enabled patterns and masks
>> *track pattern slots for the hardware limitation on the
>> maximum number of patterns that can be stored.
>> *track interrupts enabled before WoW suspend, so
>> that can be reconfigured after resume
>> *have macros to parse user defined wow configurations to
>> hardware code
>>
>> Cc: Senthil Balasubramanian<senthilb@qca.qualcomm.com>
>> Cc: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>> Cc: vadivel@qca.qualcomm.com
>> Tested-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> Signed-off-by: Luis R. Rodriguez<mcgrof@qca.qualcomm.com>
>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath9k/ath9k.h | 20 ++++++++++++++++++++
>> drivers/net/wireless/ath/ath9k/hw.h | 21 +++++++++++++++++++++
>> 2 files changed, 41 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
>> index a8c0500..264c25b 100644
>> --- a/drivers/net/wireless/ath/ath9k/ath9k.h
>> +++ b/drivers/net/wireless/ath/ath9k/ath9k.h
>> @@ -505,6 +505,19 @@ static inline u16 ath9k_btcoex_aggr_limit(struct ath_softc *sc,
>> }
>> #endif /* CONFIG_ATH9K_BTCOEX_SUPPORT */
>>
>> +struct ath9k_wow_pattern {
>> + bool slot;
>> + u8 pattern_bytes[MAX_PATTERN_SIZE];
>> + u8 mask_bytes[MAX_PATTERN_SIZE];
>> + u32 pattern_len;
>> + struct list_head list;
>> +};
>> +
>> +struct ath9k_wow_info {
>> + u32 num_of_patterns;
>> + struct list_head wow_patterns;
>> +};
>> +
>> /********************/
>> /* LED Control */
>> /********************/
>> @@ -706,6 +719,13 @@ struct ath_softc {
>> struct ath_ant_comb ant_comb;
>> u8 ant_tx, ant_rx;
>> struct dfs_pattern_detector *dfs_detector;
>> +
>> +#ifdef CONFIG_PM_SLEEP
>> + bool wow_got_bmiss_intr;
>> + bool wow_sleep_proc_intr; /* in the middle of WoW sleep ? */
>> + u32 wow_intr_before_sleep;
>> + struct ath9k_wow_info wow_info;
>> +#endif
>> };
>>
>> void ath9k_tasklet(unsigned long data);
>> diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h
>> index 03d5909..d0e14a3 100644
>> --- a/drivers/net/wireless/ath/ath9k/hw.h
>> +++ b/drivers/net/wireless/ath/ath9k/hw.h
>> @@ -179,6 +179,24 @@
>> #define PAPRD_TABLE_SZ 24
>> #define PAPRD_IDEAL_AGC2_PWR_RANGE 0xe0
>>
>> +/* Wake on Wireless */
>> +
>> +#define MAX_PATTERN_SIZE 256
>> +#define MAX_PATTERN_MASK_SIZE 32
>> +#define MAX_NUM_PATTERN 8
>> +#define MAX_NUM_USER_PATTERN 6 /* deducting the disassociate and
>> + deauthenticate packets */
>> +
>> +/*
>> + * WoW trigger mapping to hardware code
>> + */
>> +
>> +#define AH_WOW_USER_PATTERN_EN BIT(0)
>> +#define AH_WOW_MAGIC_PATTERN_EN BIT(1)
>> +#define AH_WOW_LINK_CHANGE BIT(2)
>> +#define AH_WOW_BEACON_MISS BIT(3)
>> +#define AH_WOW_MAX_EVENTS 4
> Why do you need AH_WOW_MAX_EVENT? It looks like out of sync and also it is never be used.
i will correct this out in v2. also found few more unused stuff, will
correct it out. thanks for your review.
--
thanks,
shafi
next prev parent reply other threads:[~2012-06-20 5:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 15:47 [ath9k-devel] [PATCH 00/10] Add support for WOW in ath9k Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 01/10] ath9k_hw: Add register definitions for WoW support Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 16:52 ` [ath9k-devel] " Thiagarajan, Vasanthakumar
2012-06-19 16:52 ` Thiagarajan, Vasanthakumar
2012-06-19 15:47 ` [ath9k-devel] [PATCH 02/10] ath9k: Add definitions and structures to support WoW Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 17:38 ` [ath9k-devel] " Rajkumar Manoharan
2012-06-19 17:38 ` Rajkumar Manoharan
2012-06-20 5:05 ` Mohammed Shafi Shajakhan [this message]
2012-06-20 5:05 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 03/10] ath9k_hw: Add WoW hardware capability flags Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 17:20 ` [ath9k-devel] " Rajkumar Manoharan
2012-06-19 17:20 ` Rajkumar Manoharan
2012-06-20 5:10 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-06-20 5:10 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 04/10] ath9k_hw: advertise WoW support for capable chipsets Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 05/10] ath9k: advertise supported WoW flags to upper layer Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-20 0:37 ` [ath9k-devel] " Julian Calaby
2012-06-20 0:37 ` Julian Calaby
2012-06-20 5:13 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-06-20 5:13 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 06/10] ath9k_hw: INI changes for WoW for AR9002 chipsets Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 07/10] ath9k_hw: Add hardware code for WoW Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 17:50 ` [ath9k-devel] " Rajkumar Manoharan
2012-06-19 17:50 ` Rajkumar Manoharan
2012-06-20 5:16 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-06-20 5:16 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 08/10] ath: Add Wake-on-Wireless debug mask Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 09/10] ath9k: Add WoW related mac80211 callbacks Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 10/10] ath9k: do not disable hardware while wow is enabled Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE15A17.9040804@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.