From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 05/10] ath9k: advertise supported WoW flags to upper layer
Date: Wed, 20 Jun 2012 10:43:02 +0530 [thread overview]
Message-ID: <4FE15BDE.10407@qca.qualcomm.com> (raw)
In-Reply-To: <CAGRGNgUhCvTVaCd7KxuvP5ZUNED2vN7yFHdL27Jp+sg183KobQ@mail.gmail.com>
Hi Julian,
>
> On Wed, Jun 20, 2012 at 1:47 AM, Mohammed Shafi Shajakhan
> <mohammed@qca.qualcomm.com> wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> currently the code supports WoW triggers due to
>> *magic packet
>> *user defined patterns
>> *deauth and disassoc patterns
>> *disconnect - beacon miss, last beacon received timeout,
>> no ack for keeep alive frames.
>>
>> we need to support other WoW offload features in the
>> near future. also a minor cleanup.
>>
>> Cc: Senthil Balasubramanian<senthilb@qca.qualcomm.com>
>> Cc: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>> Cc: vadivel at qca.qualcomm.com
>> Tested-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> Signed-off-by: Luis R. Rodriguez<mcgrof@qca.qualcomm.com>
>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath9k/init.c | 20 ++++++++++++++++++--
>> 1 files changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
>> index 9dfce1a..d08824f 100644
>> --- a/drivers/net/wireless/ath/ath9k/init.c
>> +++ b/drivers/net/wireless/ath/ath9k/init.c
>> @@ -688,8 +688,8 @@ void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
>> IEEE80211_HW_SPECTRUM_MGMT |
>> IEEE80211_HW_REPORTS_TX_ACK_STATUS;
>>
>> - if (sc->sc_ah->caps.hw_caps& ATH9K_HW_CAP_HT)
>> - hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
>> + if (ah->caps.hw_caps& ATH9K_HW_CAP_HT)
>> + hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
>
> This doesn't look like it belongs with the rest of the patch.
>
its a minor cleanup, but would be best to do it separately. there is
also another place i did this thing, thanks i will address in v2.
--
thanks,
shafi
WARNING: multiple messages have this Message-ID (diff)
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Julian Calaby <julian.calaby@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>, <ath9k-devel@lists.ath9k.org>,
Rajkumar Manoharan <rmanohar@qca.qualcomm.com>,
Sujith Manoharan <c_manoha@qca.qualcomm.com>,
<vadivel@qca.qualcomm.com>, <rhu@qca.qualcomm.com>,
<aeolus@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH 05/10] ath9k: advertise supported WoW flags to upper layer
Date: Wed, 20 Jun 2012 10:43:02 +0530 [thread overview]
Message-ID: <4FE15BDE.10407@qca.qualcomm.com> (raw)
In-Reply-To: <CAGRGNgUhCvTVaCd7KxuvP5ZUNED2vN7yFHdL27Jp+sg183KobQ@mail.gmail.com>
Hi Julian,
>
> On Wed, Jun 20, 2012 at 1:47 AM, Mohammed Shafi Shajakhan
> <mohammed@qca.qualcomm.com> wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> currently the code supports WoW triggers due to
>> *magic packet
>> *user defined patterns
>> *deauth and disassoc patterns
>> *disconnect - beacon miss, last beacon received timeout,
>> no ack for keeep alive frames.
>>
>> we need to support other WoW offload features in the
>> near future. also a minor cleanup.
>>
>> Cc: Senthil Balasubramanian<senthilb@qca.qualcomm.com>
>> Cc: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>> Cc: vadivel@qca.qualcomm.com
>> Tested-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> Signed-off-by: Luis R. Rodriguez<mcgrof@qca.qualcomm.com>
>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> ---
>> drivers/net/wireless/ath/ath9k/init.c | 20 ++++++++++++++++++--
>> 1 files changed, 18 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
>> index 9dfce1a..d08824f 100644
>> --- a/drivers/net/wireless/ath/ath9k/init.c
>> +++ b/drivers/net/wireless/ath/ath9k/init.c
>> @@ -688,8 +688,8 @@ void ath9k_set_hw_capab(struct ath_softc *sc, struct ieee80211_hw *hw)
>> IEEE80211_HW_SPECTRUM_MGMT |
>> IEEE80211_HW_REPORTS_TX_ACK_STATUS;
>>
>> - if (sc->sc_ah->caps.hw_caps& ATH9K_HW_CAP_HT)
>> - hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
>> + if (ah->caps.hw_caps& ATH9K_HW_CAP_HT)
>> + hw->flags |= IEEE80211_HW_AMPDU_AGGREGATION;
>
> This doesn't look like it belongs with the rest of the patch.
>
its a minor cleanup, but would be best to do it separately. there is
also another place i did this thing, thanks i will address in v2.
--
thanks,
shafi
next prev parent reply other threads:[~2012-06-20 5:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 15:47 [ath9k-devel] [PATCH 00/10] Add support for WOW in ath9k Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 01/10] ath9k_hw: Add register definitions for WoW support Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 16:52 ` [ath9k-devel] " Thiagarajan, Vasanthakumar
2012-06-19 16:52 ` Thiagarajan, Vasanthakumar
2012-06-19 15:47 ` [ath9k-devel] [PATCH 02/10] ath9k: Add definitions and structures to support WoW Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 17:38 ` [ath9k-devel] " Rajkumar Manoharan
2012-06-19 17:38 ` Rajkumar Manoharan
2012-06-20 5:05 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-06-20 5:05 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 03/10] ath9k_hw: Add WoW hardware capability flags Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 17:20 ` [ath9k-devel] " Rajkumar Manoharan
2012-06-19 17:20 ` Rajkumar Manoharan
2012-06-20 5:10 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-06-20 5:10 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 04/10] ath9k_hw: advertise WoW support for capable chipsets Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 05/10] ath9k: advertise supported WoW flags to upper layer Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-20 0:37 ` [ath9k-devel] " Julian Calaby
2012-06-20 0:37 ` Julian Calaby
2012-06-20 5:13 ` Mohammed Shafi Shajakhan [this message]
2012-06-20 5:13 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 06/10] ath9k_hw: INI changes for WoW for AR9002 chipsets Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 07/10] ath9k_hw: Add hardware code for WoW Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 17:50 ` [ath9k-devel] " Rajkumar Manoharan
2012-06-19 17:50 ` Rajkumar Manoharan
2012-06-20 5:16 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-06-20 5:16 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 08/10] ath: Add Wake-on-Wireless debug mask Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 09/10] ath9k: Add WoW related mac80211 callbacks Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 10/10] ath9k: do not disable hardware while wow is enabled Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE15BDE.10407@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.