From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 07/10] ath9k_hw: Add hardware code for WoW
Date: Wed, 20 Jun 2012 10:46:30 +0530 [thread overview]
Message-ID: <4FE15CAE.501@qca.qualcomm.com> (raw)
In-Reply-To: <20120619175018.GB7191@vmraj-lnx.qca.qualcomm.com>
Hi Raj,
On Tuesday 19 June 2012 11:20 PM, Rajkumar Manoharan wrote:
> On Tue, Jun 19, 2012 at 09:17:27PM +0530, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> add a new file wow.c which takes care of the hardware code
>> for WoW.
> [...]
>> ---
>> 3 files changed, 591 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/net/wireless/ath/ath9k/wow.c
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wireless/ath/ath9k/Makefile
>> index 9c41232..2ad8f94 100644
>> --- a/drivers/net/wireless/ath/ath9k/Makefile
>> +++ b/drivers/net/wireless/ath/ath9k/Makefile
>> @@ -17,6 +17,7 @@ ath9k-$(CONFIG_ATH9K_DFS_CERTIFIED) += \
>> dfs.o \
>> dfs_pattern_detector.o \
>> dfs_pri_detector.o
>> +ath9k-$(CONFIG_PM_SLEEP) += wow.o
>>
>> obj-$(CONFIG_ATH9K) += ath9k.o
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h
>> index 2a20216..8e417c1 100644
>> --- a/drivers/net/wireless/ath/ath9k/hw.h
>> +++ b/drivers/net/wireless/ath/ath9k/hw.h
>> @@ -1110,6 +1110,37 @@ ath9k_hw_get_btcoex_scheme(struct ath_hw *ah)
>> }
>> #endif /* CONFIG_ATH9K_BTCOEX_SUPPORT */
>>
>> +
>> +#ifdef CONFIG_PM_SLEEP
>> +const char *ath9k_hw_wow_event_to_string(u32 wow_event);
>> +void ath9k_hw_wow_apply_pattern(struct ath_hw *ah, u8 *user_pattern,
>> + u8 *user_mask, int pattern_count,
>> + int pattern_len);
>> +u32 ath9k_hw_wow_wakeup(struct ath_hw *ah);
>> +void ath9k_hw_wow_enable(struct ath_hw *ah, u32 pattern_enable);
>> +#else
>> +static inline const char *ath9k_hw_wow_event_to_string(u32 wow_event)
>> +{
>> + return NULL;
>> +}
>> +static inline void ath9k_hw_wow_apply_pattern(struct ath_hw *ah,
>> + u8 *user_pattern, u8 *user_mask,
>> + int pattern_count,
>> + int pattern_len)
>> +{
>> + return;
>> +}
> No need to return void function and also fix indent for arguments
sorry, will address this.
>> +static inline u32 ath9k_hw_wow_wakeup(struct ath_hw *ah)
>> +{
>> + return 0;
>> +}
>> +static inline void ath9k_hw_wow_enable(struct ath_hw *ah, u32 pattern_enable)
>> +{
>> +}
>> +#endif
>> +
>> +
>> +
>> #define ATH9K_CLOCK_RATE_CCK 22
>> #define ATH9K_CLOCK_RATE_5GHZ_OFDM 40
>> #define ATH9K_CLOCK_RATE_2GHZ_OFDM 44
>> diff --git a/drivers/net/wireless/ath/ath9k/wow.c b/drivers/net/wireless/ath/ath9k/wow.c
>> new file mode 100644
>> index 0000000..66a7a74
>> --- /dev/null
>> +++ b/drivers/net/wireless/ath/ath9k/wow.c
>> @@ -0,0 +1,559 @@
>> +
>> +/*
>> + * Copyright (c) 2008-2011 Atheros Communications Inc.
>> + *
> Please update the Copyright.
sure, thanks!
>
>> +
>> +#include<linux/export.h>
>> +#include "ath9k.h"
>> +#include "reg.h"
>> +#include "hw-ops.h"
>> +
> [...]
>> + if (AR_SREV_9285(ah) || AR_SREV_9287(ah))
>> + set = AR9285_WA_DEFAULT;
>> + else
>> + set = AR9280_WA_DEFAULT;
>> +
>> + /*
>> + * In AR9280 and AR9285, bit 14 in WA register
>> + * (disable L1) should only be set when device
>> + * enters D3 state and be cleared when device
>> + * comes back to D0
>> + */
>> +
>> + if (ah->config.pcie_waen& AR_WA_D3_L1_DISABLE)
>> + set = set | AR_WA_D3_L1_DISABLE;
>> +
>> + clr = AR_WA_UNTIE_RESET_EN;
>> + set = set | AR_WA_RESET_EN | AR_WA_POR_SHORT;
> simplify it as |=
>
oh ok ,sorry i missed it. thanks.
--
thanks,
shafi
WARNING: multiple messages have this Message-ID (diff)
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>,
Rodriguez Luis <rodrigue@qca.qualcomm.com>,
<ath9k-devel@lists.ath9k.org>,
Sujith Manoharan <c_manoha@qca.qualcomm.com>,
<vadivel@qca.qualcomm.com>, <rhu@qca.qualcomm.com>,
<aeolus@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH 07/10] ath9k_hw: Add hardware code for WoW
Date: Wed, 20 Jun 2012 10:46:30 +0530 [thread overview]
Message-ID: <4FE15CAE.501@qca.qualcomm.com> (raw)
In-Reply-To: <20120619175018.GB7191@vmraj-lnx.qca.qualcomm.com>
Hi Raj,
On Tuesday 19 June 2012 11:20 PM, Rajkumar Manoharan wrote:
> On Tue, Jun 19, 2012 at 09:17:27PM +0530, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> add a new file wow.c which takes care of the hardware code
>> for WoW.
> [...]
>> ---
>> 3 files changed, 591 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/net/wireless/ath/ath9k/wow.c
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wireless/ath/ath9k/Makefile
>> index 9c41232..2ad8f94 100644
>> --- a/drivers/net/wireless/ath/ath9k/Makefile
>> +++ b/drivers/net/wireless/ath/ath9k/Makefile
>> @@ -17,6 +17,7 @@ ath9k-$(CONFIG_ATH9K_DFS_CERTIFIED) += \
>> dfs.o \
>> dfs_pattern_detector.o \
>> dfs_pri_detector.o
>> +ath9k-$(CONFIG_PM_SLEEP) += wow.o
>>
>> obj-$(CONFIG_ATH9K) += ath9k.o
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/hw.h b/drivers/net/wireless/ath/ath9k/hw.h
>> index 2a20216..8e417c1 100644
>> --- a/drivers/net/wireless/ath/ath9k/hw.h
>> +++ b/drivers/net/wireless/ath/ath9k/hw.h
>> @@ -1110,6 +1110,37 @@ ath9k_hw_get_btcoex_scheme(struct ath_hw *ah)
>> }
>> #endif /* CONFIG_ATH9K_BTCOEX_SUPPORT */
>>
>> +
>> +#ifdef CONFIG_PM_SLEEP
>> +const char *ath9k_hw_wow_event_to_string(u32 wow_event);
>> +void ath9k_hw_wow_apply_pattern(struct ath_hw *ah, u8 *user_pattern,
>> + u8 *user_mask, int pattern_count,
>> + int pattern_len);
>> +u32 ath9k_hw_wow_wakeup(struct ath_hw *ah);
>> +void ath9k_hw_wow_enable(struct ath_hw *ah, u32 pattern_enable);
>> +#else
>> +static inline const char *ath9k_hw_wow_event_to_string(u32 wow_event)
>> +{
>> + return NULL;
>> +}
>> +static inline void ath9k_hw_wow_apply_pattern(struct ath_hw *ah,
>> + u8 *user_pattern, u8 *user_mask,
>> + int pattern_count,
>> + int pattern_len)
>> +{
>> + return;
>> +}
> No need to return void function and also fix indent for arguments
sorry, will address this.
>> +static inline u32 ath9k_hw_wow_wakeup(struct ath_hw *ah)
>> +{
>> + return 0;
>> +}
>> +static inline void ath9k_hw_wow_enable(struct ath_hw *ah, u32 pattern_enable)
>> +{
>> +}
>> +#endif
>> +
>> +
>> +
>> #define ATH9K_CLOCK_RATE_CCK 22
>> #define ATH9K_CLOCK_RATE_5GHZ_OFDM 40
>> #define ATH9K_CLOCK_RATE_2GHZ_OFDM 44
>> diff --git a/drivers/net/wireless/ath/ath9k/wow.c b/drivers/net/wireless/ath/ath9k/wow.c
>> new file mode 100644
>> index 0000000..66a7a74
>> --- /dev/null
>> +++ b/drivers/net/wireless/ath/ath9k/wow.c
>> @@ -0,0 +1,559 @@
>> +
>> +/*
>> + * Copyright (c) 2008-2011 Atheros Communications Inc.
>> + *
> Please update the Copyright.
sure, thanks!
>
>> +
>> +#include<linux/export.h>
>> +#include "ath9k.h"
>> +#include "reg.h"
>> +#include "hw-ops.h"
>> +
> [...]
>> + if (AR_SREV_9285(ah) || AR_SREV_9287(ah))
>> + set = AR9285_WA_DEFAULT;
>> + else
>> + set = AR9280_WA_DEFAULT;
>> +
>> + /*
>> + * In AR9280 and AR9285, bit 14 in WA register
>> + * (disable L1) should only be set when device
>> + * enters D3 state and be cleared when device
>> + * comes back to D0
>> + */
>> +
>> + if (ah->config.pcie_waen& AR_WA_D3_L1_DISABLE)
>> + set = set | AR_WA_D3_L1_DISABLE;
>> +
>> + clr = AR_WA_UNTIE_RESET_EN;
>> + set = set | AR_WA_RESET_EN | AR_WA_POR_SHORT;
> simplify it as |=
>
oh ok ,sorry i missed it. thanks.
--
thanks,
shafi
next prev parent reply other threads:[~2012-06-20 5:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 15:47 [ath9k-devel] [PATCH 00/10] Add support for WOW in ath9k Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 01/10] ath9k_hw: Add register definitions for WoW support Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 16:52 ` [ath9k-devel] " Thiagarajan, Vasanthakumar
2012-06-19 16:52 ` Thiagarajan, Vasanthakumar
2012-06-19 15:47 ` [ath9k-devel] [PATCH 02/10] ath9k: Add definitions and structures to support WoW Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 17:38 ` [ath9k-devel] " Rajkumar Manoharan
2012-06-19 17:38 ` Rajkumar Manoharan
2012-06-20 5:05 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-06-20 5:05 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 03/10] ath9k_hw: Add WoW hardware capability flags Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 17:20 ` [ath9k-devel] " Rajkumar Manoharan
2012-06-19 17:20 ` Rajkumar Manoharan
2012-06-20 5:10 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-06-20 5:10 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 04/10] ath9k_hw: advertise WoW support for capable chipsets Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 05/10] ath9k: advertise supported WoW flags to upper layer Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-20 0:37 ` [ath9k-devel] " Julian Calaby
2012-06-20 0:37 ` Julian Calaby
2012-06-20 5:13 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2012-06-20 5:13 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 06/10] ath9k_hw: INI changes for WoW for AR9002 chipsets Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 07/10] ath9k_hw: Add hardware code for WoW Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 17:50 ` [ath9k-devel] " Rajkumar Manoharan
2012-06-19 17:50 ` Rajkumar Manoharan
2012-06-20 5:16 ` Mohammed Shafi Shajakhan [this message]
2012-06-20 5:16 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 08/10] ath: Add Wake-on-Wireless debug mask Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 09/10] ath9k: Add WoW related mac80211 callbacks Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
2012-06-19 15:47 ` [ath9k-devel] [PATCH 10/10] ath9k: do not disable hardware while wow is enabled Mohammed Shafi Shajakhan
2012-06-19 15:47 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE15CAE.501@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.