All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiang Liu <jiang.liu@huawei.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Taku Izumi <izumi.taku@jp.fujitsu.com>,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	Don Dutile <ddutile@redhat.com>,
	Yijing Wang <wangyijing@huawei.com>,
	Keping Chen <chenkeping@huawei.com>, <linux-pci@vger.kernel.org>,
	Jiang Liu <liuj97@gmail.com>
Subject: Re: [PATCH v8 06/12] PCI/ACPI: provide MCFG address for PCI host bridges
Date: Wed, 20 Jun 2012 16:32:27 +0800	[thread overview]
Message-ID: <4FE18A9B.9040501@huawei.com> (raw)
In-Reply-To: <CAE9FiQWAPb7S9kBrebnf6nn2KmCL2ohUbukycJPGQLB=11+_pA@mail.gmail.com>

Hi Yinghai,
> thought you were agreeing to go through choice 2 without caching MCFG anymore.
> 
> Can you just drop that caching MCFG and only handle _CBA here?
> 
> Thanks
> 
> Yinghai

	Yes, I'm going to adopt solution two as you suggested. 
On the other hand, the MMCFG caching is kept due to following
considerations:
1) To emit a warning message if MMCFG entries in MCFG table only
partially covers buses under a PCI host bridge. Taku reported that
he has a system which exhibits such a behavior.
2) To cross-check that MMCFG addresses returned by MCFG table and 
_CBA method are consistent if both are available (though that 
violates the PCI FW/ACPI specifications).
3) In future, we may try to remove MMCFG entry constructed from
MCFG table when hot-removing a PCI host bridge. We have some systems
which assign a distinguish segment ID for each host bridge. In such
a case, it may be reasonable to remove the MMCFG entry when removing
a host bridge.
4) The MCFG cache should be small under normal cases.

	If you feel it's unnecessary to keep the cache, I will remove
it and send out a updated version soon.
	Thanks!
	Gerry


  reply	other threads:[~2012-06-20  8:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19 13:15 [PATCH v8 00/12] PCI, x86: update MMCFG information when hot-plugging PCI host bridges Jiang Liu
2012-06-19 13:15 ` [PATCH v8 01/12] x86/PCI: split out pci_mmcfg_check_reserved() for code reuse Jiang Liu
2012-06-19 13:15 ` [PATCH v8 02/12] x86/PCI: split out pci_mmconfig_alloc() " Jiang Liu
2012-06-19 13:15 ` [PATCH v8 03/12] x86/PCI: use RCU list to protect mmconfig list Jiang Liu
2012-06-19 13:15 ` [PATCH v8 04/12] x86/PCI: introduce pci_mmcfg_arch_map()/pci_mmcfg_arch_unmap() Jiang Liu
2012-06-19 13:15 ` [PATCH v8 05/12] x86/PCI: add pci_mmconfig_insert()/delete() for PCI root bridge hotplug Jiang Liu
2012-06-19 13:15 ` [PATCH v8 06/12] PCI/ACPI: provide MCFG address for PCI host bridges Jiang Liu
2012-06-19 18:34   ` Yinghai Lu
2012-06-20  8:32     ` Jiang Liu [this message]
2012-06-20 18:03       ` Yinghai Lu
2012-06-21  1:36         ` Jiang Liu
2012-06-19 13:15 ` [PATCH v8 07/12] x86/PCI: update MMCFG information when hot-plugging " Jiang Liu
2012-06-19 13:15 ` [PATCH v8 08/12] x86/PCI: simplify pci_mmcfg_late_insert_resources() Jiang Liu
2012-06-19 13:15 ` [PATCH v8 09/12] x86/PCI: get rid of redundant log messages Jiang Liu
2012-06-19 13:15 ` [PATCH v8 10/12] x86/PCI: refine __pci_mmcfg_init() for better code readability Jiang Liu
2012-06-19 18:31   ` Yinghai Lu
2012-06-20  8:50     ` Jiang Liu
2012-06-19 13:15 ` [PATCH v8 11/12] ACPI: mark acpi_sfi_table_parse() as __init Jiang Liu
2012-06-19 13:15   ` Jiang Liu
2012-06-19 13:15 ` [RFC PATCH v8 12/12] x86/PCI: add MMCFG information on demand Jiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE18A9B.9040501@huawei.com \
    --to=jiang.liu@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=chenkeping@huawei.com \
    --cc=ddutile@redhat.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=liuj97@gmail.com \
    --cc=wangyijing@huawei.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.