From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludovic.desroches Subject: Fwd: Re: [PATCH] mmc: at91: fix bus speed Date: Wed, 20 Jun 2012 11:13:07 +0200 Message-ID: <4FE19423.4010103@atmel.com> References: <4FE18E84.9000603@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4FE18E84.9000603@atmel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: linux-mmc@vger.kernel.org Cc: ludovic.desroches@atmel.com, =?UTF-8?B?UHJjaGFsIEppxZnDrQ==?= , "linux-arm-kernel@lists.infradead.org" List-Id: linux-mmc@vger.kernel.org QWRkIG1tYyBtYWlsaW5nIGxpc3QuCgoKLS0tLS0tLS0gTWVzc2FnZSBvcmlnaW5hbCAtLS0tLS0t LQpTdWpldDogUmU6IFtQQVRDSF0gIG1tYzogYXQ5MTogZml4IGJ1cyBzcGVlZApEYXRlIDogV2Vk LCAyMCBKdW4gMjAxMiAxMDo0OTowOCArMDIwMApEZSA6IGx1ZG92aWMuZGVzcm9jaGVzIDxsdWRv dmljLmRlc3JvY2hlc0BhdG1lbC5jb20+ClBvdXIgOiBQcmNoYWwgSmnFmcOtIDxqaXJpLnByY2hh bEBha3NpZ25hbC5jej4KQ29waWUgw6AgOiA8bHVkb3ZpYy5kZXNyb2NoZXNAYXRtZWwuY29tPiwg CjxsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc+CgpIZWxsbyBKaXJpLAoKVGhh bmtzIGZvciB5b3VyIHBhdGNoIGJ1dCBhdDkxLW1jaSBpcyBub3cgZGVwcmVjYXRlZCBhbmQgc2hv dWxkIGJlCnJlbW92ZWQgaW4gMy43LgpPbiBvbmUgaGFuZCBJIGRvbid0IGtub3cgaWYgd2UgaGF2 ZSB0byBjb250aW51ZSB0byB0YWtlIHBhdGNoZXMgZm9yIHRoaXMKZHJpdmVyLCBvbiB0aGUgb3Ro ZXIgaGFuZCBpdCdzIGEgZml4IGZvciBzb21lIFNEIGNhcmRzLgoKTGUgMDYvMjAvMjAxMiAxMDox NSBBTSwgUHJjaGFsIEppxZnDrSBhIMOpY3JpdCA6Cj4gVGhpcyBwYXRjaCBjaGFuZ2UgbWluaW11 bSBhbmQgbWF4aW11bSBjbG9jayBzcGVlZCBiZWNhdXNlIHNvbWUgbm9uYW1lCj4gY2FyZHMgZG9l c24ndCB3b3JrIGR1cmluZyBpbml0IGV2ZW4gYXQgMzc1a0h6IGFuZCBuZXcgY2FyZHMgKFNEIHYu IDMuMCkKPiBjYW4gcnVuIGF0IDUwIG9yIDEwMCBNSHouCj4gQWxzbyBhZGVkIGNsa2RpdiByZWdp c3RlciBvdmVycnVuIGZpeCB3aGVuIHNldHRpbmcgbG93IHNwZWVkcy4KPgo+IFNpZ25lZC1vZmYt Ynk6IEppcmkgUHJjaGFsIDxqaXJpLnByY2hhbEBha3NpZ25hbC5jej4KPiAtLS0KPgo+IC0tLSBs aW51eC9saW51eC0zLjUtcmMzL2RyaXZlcnMvbW1jL2hvc3QvYXQ5MV9tY2kuYy5vcmlnICAgIDIw MTItMDYtMTcKPiAwMjoyNToxNy4wMDAwMDAwMDAgKzAyMDAKPiArKysgbGludXgvbGludXgtMy41 LXJjMy9kcml2ZXJzL21tYy9ob3N0L2F0OTFfbWNpLmMgICAgMjAxMi0wNi0xOAo+IDExOjAxOjQ5 Ljc1MTQxNTk4NCArMDIwMAo+IEBAIC03MjQsNiArNzI0LDEwIEBAIHN0YXRpYyB2b2lkIGF0OTFf bWNpX3NldF9pb3Moc3RydWN0IG1tY18KPiAgICAgICAgICAgZWxzZQo+ICAgICAgICAgICAgICAg Y2xrZGl2ID0gKGF0OTFfbWFzdGVyX2Nsb2NrIC8gaW9zLT5jbG9jaykgLyAyOwo+Cj4gKyAgICAg ICAgLyogc2V0IG1heGltdW0gZGl2aWRlciAqLwo+ICsgICAgICAgIGlmIChjbGtkaXYgPiAyNTUp Cj4gKyAgICAgICAgICAgIGNsa2RpdiA9IDI1NTsKPiArCj4gICAgICAgICAgIHByX2RlYnVnKCJj bGtkaXYgPSAlZC4gbWNjayA9ICVsZFxuIiwgY2xrZGl2LAo+ICAgICAgICAgICAgICAgYXQ5MV9t YXN0ZXJfY2xvY2sgLyAoMiAqIChjbGtkaXYgKyAxKSkpOwo+ICAgICAgIH0KPiBAQCAtOTQ4LDgg Kzk1Miw4IEBAIHN0YXRpYyBpbnQgX19pbml0IGF0OTFfbWNpX3Byb2JlKHN0cnVjdAo+ICAgICAg IH0KPgo+ICAgICAgIG1tYy0+b3BzID0gJmF0OTFfbWNpX29wczsKPiAtICAgIG1tYy0+Zl9taW4g PSAzNzUwMDA7Cj4gLSAgICBtbWMtPmZfbWF4ID0gMjUwMDAwMDA7Cj4gKyAgICBtbWMtPmZfbWlu ID0gMjAwMDAwOyAvKiBub3QgYWxsIGNhcmRzIGNhbiBydW4gYXQgMzc1a0h6ICovCgpJIHdpbGwg Y2hlY2sgb24gYXRtZWwtbWNpIGlmIHdlIGhhdmUgdG8gZGVjcmVhc2UgZl9taW4uCgo+ICsgICAg bW1jLT5mX21heCA9IDEwMDAwMDAwMDsgLyogbmV3IGNhcmRzIGNhbiBydW4gYXQgMTAwTUh6ICov CgpNQ0kgb3BlcmF0ZXMgYXQgYSByYXRlIG9mIHVwIHRvIG1hc3RlciBjbG9jayBkaXZpZGVkIGJ5 IHR3byBzbyB5b3UgY2FuJ3QKcmVhY2ggMTAwTUh6IGFzIG1heCBmcmVxdWVuY3kgc2luY2UgaXQg bWVhbnMgdGhhdCBvdXIgbWFzdGVyIGNsb2NrIGlzIGF0CjIwME1IeiB0aGF0IGlzIG5vdCB0aGUg Y2FzZS4gSSB3b3VsZCBzYXkgNTBNSHogaXMgdGhlIG1heGltdW0gZnJlcXVlbmN5CmZvciBwcm9k dWN0IGNvbXBhdGlibGUgd2l0aCBhdDkxLW1jaS4KCj4gICAgICAgbW1jLT5vY3JfYXZhaWwgPSBN TUNfVkREXzMyXzMzIHwgTU1DX1ZERF8zM18zNDsKPiAgICAgICBtbWMtPmNhcHMgPSAwOwo+Cj4K PgoKUmVnYXJkcwoKTHVkb3ZpYwoKCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludovic.desroches@atmel.com (ludovic.desroches) Date: Wed, 20 Jun 2012 11:13:07 +0200 Subject: Fwd: Re: [PATCH] mmc: at91: fix bus speed In-Reply-To: <4FE18E84.9000603@atmel.com> References: <4FE18E84.9000603@atmel.com> Message-ID: <4FE19423.4010103@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Add mmc mailing list. -------- Message original -------- Sujet: Re: [PATCH] mmc: at91: fix bus speed Date : Wed, 20 Jun 2012 10:49:08 +0200 De : ludovic.desroches Pour : Prchal Ji?? Copie ? : , Hello Jiri, Thanks for your patch but at91-mci is now deprecated and should be removed in 3.7. On one hand I don't know if we have to continue to take patches for this driver, on the other hand it's a fix for some SD cards. Le 06/20/2012 10:15 AM, Prchal Ji?? a ?crit : > This patch change minimum and maximum clock speed because some noname > cards doesn't work during init even at 375kHz and new cards (SD v. 3.0) > can run at 50 or 100 MHz. > Also aded clkdiv register overrun fix when setting low speeds. > > Signed-off-by: Jiri Prchal > --- > > --- linux/linux-3.5-rc3/drivers/mmc/host/at91_mci.c.orig 2012-06-17 > 02:25:17.000000000 +0200 > +++ linux/linux-3.5-rc3/drivers/mmc/host/at91_mci.c 2012-06-18 > 11:01:49.751415984 +0200 > @@ -724,6 +724,10 @@ static void at91_mci_set_ios(struct mmc_ > else > clkdiv = (at91_master_clock / ios->clock) / 2; > > + /* set maximum divider */ > + if (clkdiv > 255) > + clkdiv = 255; > + > pr_debug("clkdiv = %d. mcck = %ld\n", clkdiv, > at91_master_clock / (2 * (clkdiv + 1))); > } > @@ -948,8 +952,8 @@ static int __init at91_mci_probe(struct > } > > mmc->ops = &at91_mci_ops; > - mmc->f_min = 375000; > - mmc->f_max = 25000000; > + mmc->f_min = 200000; /* not all cards can run at 375kHz */ I will check on atmel-mci if we have to decrease f_min. > + mmc->f_max = 100000000; /* new cards can run at 100MHz */ MCI operates at a rate of up to master clock divided by two so you can't reach 100MHz as max frequency since it means that our master clock is at 200MHz that is not the case. I would say 50MHz is the maximum frequency for product compatible with at91-mci. > mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34; > mmc->caps = 0; > > > Regards Ludovic