Re: [PATCH 3/3] can: af_can: fix sparse warning for can_rx_alldev_list

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 20.06.2012 10:00, Marc Kleine-Budde wrote:

> On 06/20/2012 05:39 AM, Oliver Hartkopp wrote:
>> On 19.06.2012 22:05, Marc Kleine-Budde wrote:

>> Is there no way to satisfy the sparse warning in another way?
> 
> Yes, don't use extern, put it into af_can.h.
>


So this would fix the sparse warning then?

diff --git a/net/can/af_can.h b/net/can/af_can.h
index fd882db..1dccb4c 100644
--- a/net/can/af_can.h
+++ b/net/can/af_can.h
@@ -104,6 +104,9 @@ struct s_pstats {
 	unsigned long rcv_entries_max;
 };

+/* receive filters subscribed for 'all' CAN devices */
+extern struct dev_rcv_lists can_rx_alldev_list;
+
 /* function prototypes for the CAN networklayer procfs (proc.c) */
 extern void can_init_proc(void);
 extern void can_remove_proc(void);
diff --git a/net/can/proc.c b/net/can/proc.c
index ba873c3..3b6dd31 100644
--- a/net/can/proc.c
+++ b/net/can/proc.c
@@ -83,9 +83,6 @@ static const char rx_list_name[][8] = {
 	[RX_EFF] = "rx_eff",
 };

-/* receive filters subscribed for 'all' CAN devices */
-extern struct dev_rcv_lists can_rx_alldev_list;
-
 /*
  * af_can statistics stuff
  */