From: Randy Dunlap <rdunlap@xenotime.net>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
Myungjoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd: MFD_MAX77693 needs to select IRQ_DOMAIN
Date: Wed, 20 Jun 2012 12:54:17 -0700 [thread overview]
Message-ID: <4FE22A69.3090309@xenotime.net> (raw)
In-Reply-To: <1340156457.13830.1.camel@phoenix>
On 06/19/2012 06:40 PM, Axel Lin wrote:
> This fixes below build errors:
>
> CC drivers/mfd/max77693-irq.o
> drivers/mfd/max77693-irq.c: In function 'max77693_irq_thread':
> drivers/mfd/max77693-irq.c:217:4: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
> drivers/mfd/max77693-irq.c: In function 'max77693_irq_init':
> drivers/mfd/max77693-irq.c:286:2: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
> drivers/mfd/max77693-irq.c:286:9: warning: assignment makes pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
> make[2]: *** [drivers/mfd/max77693-irq.o] Error 1
> make[1]: *** [drivers/mfd] Error 2
> make: *** [drivers] Error 2
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index e129c82..79f1d4b 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -427,6 +427,7 @@ config MFD_MAX77693
> depends on I2C=y && GENERIC_HARDIRQS
> select MFD_CORE
> select REGMAP_I2C
> + select IRQ_DOMAIN
> help
> Say yes here to support for Maxim Semiconductor MAX77693.
> This is a companion Power Management IC with Flash, Haptic, Charger,
--
~Randy
prev parent reply other threads:[~2012-06-20 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 1:40 [PATCH] mfd: MFD_MAX77693 needs to select IRQ_DOMAIN Axel Lin
2012-06-20 19:53 ` [PATCH] mfd: TWL6040_CORE " Randy Dunlap
2012-07-02 14:35 ` Samuel Ortiz
2012-06-20 19:54 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE22A69.3090309@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=axel.lin@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.