From: Eric Sandeen <sandeen@redhat.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfs_db: Fix extent record printing on big endian
Date: Wed, 20 Jun 2012 15:40:53 -0500 [thread overview]
Message-ID: <4FE23555.7070606@redhat.com> (raw)
Extent records which should have been printed as:
a.bmx[0] = [startoff,startblock,blockcount,extentflag] 0:[0,12,17,0]
for example, were instead being printed as:
a.bmx[0] = [startoff,startblock,blockcount,extentflag] 0:[0,12884910592,0,0]
in xfs_db. It was simply mis-parsing the extent records due to wrong
#defines for big-endian machines.
It's been broken since at least xfsprogs-2.6.13, causing xfstests 021
to fail.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
Why this works is, um ...left as an exercise to the reviewer for now ;)
TBH I get lost in xfs_db, and I'm not sure how endianness is handled,
but it's pretty clearly not like this!
diff --git a/db/btblock.c b/db/btblock.c
index f6e8a68..2c199b2 100644
--- a/db/btblock.c
+++ b/db/btblock.c
@@ -250,23 +250,12 @@ const field_t bmapbtd_key_flds[] = {
};
#undef KOFF
-#ifndef XFS_NATIVE_HOST
-
#define BMBT_EXNTFLAG_BITOFF 0
#define BMBT_STARTOFF_BITOFF (BMBT_EXNTFLAG_BITOFF + BMBT_EXNTFLAG_BITLEN)
#define BMBT_STARTBLOCK_BITOFF (BMBT_STARTOFF_BITOFF + BMBT_STARTOFF_BITLEN)
#define BMBT_BLOCKCOUNT_BITOFF \
(BMBT_STARTBLOCK_BITOFF + BMBT_STARTBLOCK_BITLEN)
-#else
-
-#define BMBT_EXNTFLAG_BITOFF 63
-#define BMBT_STARTOFF_BITOFF (BMBT_EXNTFLAG_BITOFF - BMBT_STARTOFF_BITLEN)
-#define BMBT_STARTBLOCK_BITOFF 85 /* 128 - 43 (other 9 is in first word) */
-#define BMBT_BLOCKCOUNT_BITOFF 64 /* Start of second 64 bit container */
-
-#endif /* XFS_NATIVE_HOST */
-
const field_t bmapbta_rec_flds[] = {
{ "startoff", FLDT_CFILEOFFA, OI(BMBT_STARTOFF_BITOFF), C1, 0,
TYP_ATTR },
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2012-06-20 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 20:40 Eric Sandeen [this message]
2012-07-06 19:07 ` [PATCH] xfs_db: Fix extent record printing on big endian Eric Sandeen
2012-07-13 8:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE23555.7070606@redhat.com \
--to=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.