All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prashanth Nageshappa <prashanth@linux.vnet.ibm.com>
To: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	mingo@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	roland@kernel.org, efault@gmx.de, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v3] sched: balance_cpu to consider other cpus in its group as target of (pinned) task
Date: Thu, 21 Jun 2012 10:54:35 +0530	[thread overview]
Message-ID: <4FE2B013.7090108@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120621042347.GA5059@linux.vnet.ibm.com>

On 06/21/2012 09:53 AM, Srivatsa Vaddagiri wrote:

> * Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com> [2012-06-21 09:10:59]:
> 
>> Hmm ..I can see loop_break being incremented here:
>>
>>                 /* take a breather every nr_migrate tasks */
>>                 if (env->loop > env->loop_break) {
>>                         env->loop_break += sched_nr_migrate_break;
> 
> One possibility is to reset env->loop here, rather than loop_break, in
> which case loop_break can remain constant across "redos" and
> "more_balances"

We cannot do this as env->loop is compared with env->loop_max. So, I
believe resetting env->loop_break along with env->loop before "redos"
and "more_balances" is the right thing to do.

- Prashanth


  reply	other threads:[~2012-06-21  5:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19 12:13 [PATCH v3] sched: balance_cpu to consider other cpus in its group as target of (pinned) task Prashanth Nageshappa
2012-06-20 17:38 ` Peter Zijlstra
2012-06-21  3:40   ` Srivatsa Vaddagiri
2012-06-21  4:23     ` Srivatsa Vaddagiri
2012-06-21  5:24       ` Prashanth Nageshappa [this message]
2012-06-21  8:34     ` Peter Zijlstra
2012-06-20 17:40 ` Peter Zijlstra
2012-07-06  6:23 ` [tip:sched/core] sched: Improve balance_cpu() " tip-bot for Srivatsa Vaddagiri
2012-07-24 14:20 ` tip-bot for Srivatsa Vaddagiri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE2B013.7090108@linux.vnet.ibm.com \
    --to=prashanth@linux.vnet.ibm.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=roland@kernel.org \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.