From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?UHJjaGFsIEppxZnDrQ==?= Subject: Re: Fwd: Re: [PATCH] mmc: at91: fix bus speed Date: Thu, 21 Jun 2012 09:56:25 +0200 Message-ID: <4FE2D3A9.6000803@aksignal.cz> References: <4FE18E84.9000603@atmel.com> <4FE19423.4010103@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4FE19423.4010103@atmel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "ludovic.desroches" Cc: linux-mmc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" List-Id: linux-mmc@vger.kernel.org SGVsbG8gTHVkb3ZpYywKSSBoYXZlIHRyaWVkIGl0IHdpdGggYXRtZWwtbWNpIGRyaXZlci4gSXQg dG9vayBtZSBsaXR0bGUgdGltZSB0byBjaGFuZ2Ugc2V0dGluZyBvZiBteSBib2FyZC4KSXQgc2Vl bXMgdG8gdHJ5IGNsb2NrIGRvd24gdG8gMjAwa0h6OgpbICAgIDUuODYwMDAwXSBtbWMwOiBtbWNf cmVzY2FuX3RyeV9mcmVxOiB0cnlpbmcgdG8gaW5pdCBjYXJkIGF0IDQwMDAwMCBIegpbICAgIDUu OTIwMDAwXSBtbWMwOiBtbWNfcmVzY2FuX3RyeV9mcmVxOiB0cnlpbmcgdG8gaW5pdCBjYXJkIGF0 IDMwMDAwMCBIegpbICAgIDUuOTgwMDAwXSBtbWMwOiBtbWNfcmVzY2FuX3RyeV9mcmVxOiB0cnlp bmcgdG8gaW5pdCBjYXJkIGF0IDIwNTA3OSBIegpBcyBJIHNlZSBpbiBkcml2ZXIgc291cmNlLCB0 aGVyZSBpcyBiZXR0ZXIgY2xrZGl2IG92ZXJydW4gd29yayBhcm91bmQuCkJ1dCBJIGRvbid0IGZp bmQgbWluIGFuZCBtYXggZnJlcSBkZWZpbml0aW9ucyBpbiB0aGlzIGRyaXZlciwgaXQgaXMgcHJv YmFibHkgc29tZXdoZXJlIGVsc2UuClNvIHRoaXMgd291bGQgYmUgT0suCgpEbmUgMjAuNi4yMDEy IDExOjEzLCBsdWRvdmljLmRlc3JvY2hlcyBuYXBzYWwoYSk6Cj4gQWRkIG1tYyBtYWlsaW5nIGxp c3QuCj4KPgo+IC0tLS0tLS0tIE1lc3NhZ2Ugb3JpZ2luYWwgLS0tLS0tLS0KPiBTdWpldDogUmU6 IFtQQVRDSF0gbW1jOiBhdDkxOiBmaXggYnVzIHNwZWVkCj4gRGF0ZSA6IFdlZCwgMjAgSnVuIDIw MTIgMTA6NDk6MDggKzAyMDAKPiBEZSA6IGx1ZG92aWMuZGVzcm9jaGVzIDxsdWRvdmljLmRlc3Jv Y2hlc0BhdG1lbC5jb20+Cj4gUG91ciA6IFByY2hhbCBKacWZw60gPGppcmkucHJjaGFsQGFrc2ln bmFsLmN6Pgo+IENvcGllIMOgIDogPGx1ZG92aWMuZGVzcm9jaGVzQGF0bWVsLmNvbT4sIDxsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc+Cj4KPiBIZWxsbyBKaXJpLAo+Cj4gVGhh bmtzIGZvciB5b3VyIHBhdGNoIGJ1dCBhdDkxLW1jaSBpcyBub3cgZGVwcmVjYXRlZCBhbmQgc2hv dWxkIGJlCj4gcmVtb3ZlZCBpbiAzLjcuCj4gT24gb25lIGhhbmQgSSBkb24ndCBrbm93IGlmIHdl IGhhdmUgdG8gY29udGludWUgdG8gdGFrZSBwYXRjaGVzIGZvciB0aGlzCj4gZHJpdmVyLCBvbiB0 aGUgb3RoZXIgaGFuZCBpdCdzIGEgZml4IGZvciBzb21lIFNEIGNhcmRzLgo+Cj4gTGUgMDYvMjAv MjAxMiAxMDoxNSBBTSwgUHJjaGFsIEppxZnDrSBhIMOpY3JpdCA6Cj4+IFRoaXMgcGF0Y2ggY2hh bmdlIG1pbmltdW0gYW5kIG1heGltdW0gY2xvY2sgc3BlZWQgYmVjYXVzZSBzb21lIG5vbmFtZQo+ PiBjYXJkcyBkb2Vzbid0IHdvcmsgZHVyaW5nIGluaXQgZXZlbiBhdCAzNzVrSHogYW5kIG5ldyBj YXJkcyAoU0Qgdi4gMy4wKQo+PiBjYW4gcnVuIGF0IDUwIG9yIDEwMCBNSHouCj4+IEFsc28gYWRl ZCBjbGtkaXYgcmVnaXN0ZXIgb3ZlcnJ1biBmaXggd2hlbiBzZXR0aW5nIGxvdyBzcGVlZHMuCj4+ Cj4+IFNpZ25lZC1vZmYtYnk6IEppcmkgUHJjaGFsIDxqaXJpLnByY2hhbEBha3NpZ25hbC5jej4K Pj4gLS0tCj4+Cj4+IC0tLSBsaW51eC9saW51eC0zLjUtcmMzL2RyaXZlcnMvbW1jL2hvc3QvYXQ5 MV9tY2kuYy5vcmlnIDIwMTItMDYtMTcKPj4gMDI6MjU6MTcuMDAwMDAwMDAwICswMjAwCj4+ICsr KyBsaW51eC9saW51eC0zLjUtcmMzL2RyaXZlcnMvbW1jL2hvc3QvYXQ5MV9tY2kuYyAyMDEyLTA2 LTE4Cj4+IDExOjAxOjQ5Ljc1MTQxNTk4NCArMDIwMAo+PiBAQCAtNzI0LDYgKzcyNCwxMCBAQCBz dGF0aWMgdm9pZCBhdDkxX21jaV9zZXRfaW9zKHN0cnVjdCBtbWNfCj4+IGVsc2UKPj4gY2xrZGl2 ID0gKGF0OTFfbWFzdGVyX2Nsb2NrIC8gaW9zLT5jbG9jaykgLyAyOwo+Pgo+PiArIC8qIHNldCBt YXhpbXVtIGRpdmlkZXIgKi8KPj4gKyBpZiAoY2xrZGl2ID4gMjU1KQo+PiArIGNsa2RpdiA9IDI1 NTsKPj4gKwo+PiBwcl9kZWJ1ZygiY2xrZGl2ID0gJWQuIG1jY2sgPSAlbGRcbiIsIGNsa2RpdiwK Pj4gYXQ5MV9tYXN0ZXJfY2xvY2sgLyAoMiAqIChjbGtkaXYgKyAxKSkpOwo+PiB9Cj4+IEBAIC05 NDgsOCArOTUyLDggQEAgc3RhdGljIGludCBfX2luaXQgYXQ5MV9tY2lfcHJvYmUoc3RydWN0Cj4+ IH0KPj4KPj4gbW1jLT5vcHMgPSAmYXQ5MV9tY2lfb3BzOwo+PiAtIG1tYy0+Zl9taW4gPSAzNzUw MDA7Cj4+IC0gbW1jLT5mX21heCA9IDI1MDAwMDAwOwo+PiArIG1tYy0+Zl9taW4gPSAyMDAwMDA7 IC8qIG5vdCBhbGwgY2FyZHMgY2FuIHJ1biBhdCAzNzVrSHogKi8KPgo+IEkgd2lsbCBjaGVjayBv biBhdG1lbC1tY2kgaWYgd2UgaGF2ZSB0byBkZWNyZWFzZSBmX21pbi4KPgo+PiArIG1tYy0+Zl9t YXggPSAxMDAwMDAwMDA7IC8qIG5ldyBjYXJkcyBjYW4gcnVuIGF0IDEwME1IeiAqLwo+Cj4gTUNJ IG9wZXJhdGVzIGF0IGEgcmF0ZSBvZiB1cCB0byBtYXN0ZXIgY2xvY2sgZGl2aWRlZCBieSB0d28g c28geW91IGNhbid0Cj4gcmVhY2ggMTAwTUh6IGFzIG1heCBmcmVxdWVuY3kgc2luY2UgaXQgbWVh bnMgdGhhdCBvdXIgbWFzdGVyIGNsb2NrIGlzIGF0Cj4gMjAwTUh6IHRoYXQgaXMgbm90IHRoZSBj YXNlLiBJIHdvdWxkIHNheSA1ME1IeiBpcyB0aGUgbWF4aW11bSBmcmVxdWVuY3kKPiBmb3IgcHJv ZHVjdCBjb21wYXRpYmxlIHdpdGggYXQ5MS1tY2kuCj4KPj4gbW1jLT5vY3JfYXZhaWwgPSBNTUNf VkREXzMyXzMzIHwgTU1DX1ZERF8zM18zNDsKPj4gbW1jLT5jYXBzID0gMDsKPj4KPj4KPj4KPgo+ IFJlZ2FyZHMKPgo+IEx1ZG92aWMKPgo+Cj4KPgo+CgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: jiri.prchal@aksignal.cz (=?UTF-8?B?UHJjaGFsIEppxZnDrQ==?=) Date: Thu, 21 Jun 2012 09:56:25 +0200 Subject: Fwd: Re: [PATCH] mmc: at91: fix bus speed In-Reply-To: <4FE19423.4010103@atmel.com> References: <4FE18E84.9000603@atmel.com> <4FE19423.4010103@atmel.com> Message-ID: <4FE2D3A9.6000803@aksignal.cz> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Ludovic, I have tried it with atmel-mci driver. It took me little time to change setting of my board. It seems to try clock down to 200kHz: [ 5.860000] mmc0: mmc_rescan_try_freq: trying to init card at 400000 Hz [ 5.920000] mmc0: mmc_rescan_try_freq: trying to init card at 300000 Hz [ 5.980000] mmc0: mmc_rescan_try_freq: trying to init card at 205079 Hz As I see in driver source, there is better clkdiv overrun work around. But I don't find min and max freq definitions in this driver, it is probably somewhere else. So this would be OK. Dne 20.6.2012 11:13, ludovic.desroches napsal(a): > Add mmc mailing list. > > > -------- Message original -------- > Sujet: Re: [PATCH] mmc: at91: fix bus speed > Date : Wed, 20 Jun 2012 10:49:08 +0200 > De : ludovic.desroches > Pour : Prchal Ji?? > Copie ? : , > > Hello Jiri, > > Thanks for your patch but at91-mci is now deprecated and should be > removed in 3.7. > On one hand I don't know if we have to continue to take patches for this > driver, on the other hand it's a fix for some SD cards. > > Le 06/20/2012 10:15 AM, Prchal Ji?? a ?crit : >> This patch change minimum and maximum clock speed because some noname >> cards doesn't work during init even at 375kHz and new cards (SD v. 3.0) >> can run at 50 or 100 MHz. >> Also aded clkdiv register overrun fix when setting low speeds. >> >> Signed-off-by: Jiri Prchal >> --- >> >> --- linux/linux-3.5-rc3/drivers/mmc/host/at91_mci.c.orig 2012-06-17 >> 02:25:17.000000000 +0200 >> +++ linux/linux-3.5-rc3/drivers/mmc/host/at91_mci.c 2012-06-18 >> 11:01:49.751415984 +0200 >> @@ -724,6 +724,10 @@ static void at91_mci_set_ios(struct mmc_ >> else >> clkdiv = (at91_master_clock / ios->clock) / 2; >> >> + /* set maximum divider */ >> + if (clkdiv > 255) >> + clkdiv = 255; >> + >> pr_debug("clkdiv = %d. mcck = %ld\n", clkdiv, >> at91_master_clock / (2 * (clkdiv + 1))); >> } >> @@ -948,8 +952,8 @@ static int __init at91_mci_probe(struct >> } >> >> mmc->ops = &at91_mci_ops; >> - mmc->f_min = 375000; >> - mmc->f_max = 25000000; >> + mmc->f_min = 200000; /* not all cards can run at 375kHz */ > > I will check on atmel-mci if we have to decrease f_min. > >> + mmc->f_max = 100000000; /* new cards can run at 100MHz */ > > MCI operates at a rate of up to master clock divided by two so you can't > reach 100MHz as max frequency since it means that our master clock is at > 200MHz that is not the case. I would say 50MHz is the maximum frequency > for product compatible with at91-mci. > >> mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34; >> mmc->caps = 0; >> >> >> > > Regards > > Ludovic > > > > >