From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludovic.desroches Subject: Re: Fwd: Re: [PATCH] mmc: at91: fix bus speed Date: Thu, 21 Jun 2012 10:23:41 +0200 Message-ID: <4FE2DA0D.2080509@atmel.com> References: <4FE18E84.9000603@atmel.com> <4FE19423.4010103@atmel.com> <4FE2D3A9.6000803@aksignal.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4FE2D3A9.6000803@aksignal.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?B?UHJjaGFsIEppxZnDrQ==?= Cc: "ludovic.desroches" , linux-mmc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" List-Id: linux-mmc@vger.kernel.org SGVsbG8gUHJjaGFsLAoKTGUgMDYvMjEvMjAxMiAwOTo1NiBBTSwgUHJjaGFsIEppxZnDrSBhIMOp Y3JpdCA6Cj4gSGVsbG8gTHVkb3ZpYywKPiBJIGhhdmUgdHJpZWQgaXQgd2l0aCBhdG1lbC1tY2kg ZHJpdmVyLiBJdCB0b29rIG1lIGxpdHRsZSB0aW1lIHRvIGNoYW5nZQo+IHNldHRpbmcgb2YgbXkg Ym9hcmQuCj4gSXQgc2VlbXMgdG8gdHJ5IGNsb2NrIGRvd24gdG8gMjAwa0h6Ogo+IFsgICAgNS44 NjAwMDBdIG1tYzA6IG1tY19yZXNjYW5fdHJ5X2ZyZXE6IHRyeWluZyB0byBpbml0IGNhcmQgYXQg NDAwMDAwIEh6Cj4gWyAgICA1LjkyMDAwMF0gbW1jMDogbW1jX3Jlc2Nhbl90cnlfZnJlcTogdHJ5 aW5nIHRvIGluaXQgY2FyZCBhdCAzMDAwMDAgSHoKPiBbICAgIDUuOTgwMDAwXSBtbWMwOiBtbWNf cmVzY2FuX3RyeV9mcmVxOiB0cnlpbmcgdG8gaW5pdCBjYXJkIGF0IDIwNTA3OSBIego+IEFzIEkg c2VlIGluIGRyaXZlciBzb3VyY2UsIHRoZXJlIGlzIGJldHRlciBjbGtkaXYgb3ZlcnJ1biB3b3Jr IGFyb3VuZC4KClllcyBpdCB3YXMgd2VsbCBtYW5hZ2VkIGluIHRoaXMgZHJpdmVyLgoKPiBCdXQg SSBkb24ndCBmaW5kIG1pbiBhbmQgbWF4IGZyZXEgZGVmaW5pdGlvbnMgaW4gdGhpcyBkcml2ZXIs IGl0IGlzCj4gcHJvYmFibHkgc29tZXdoZXJlIGVsc2UuCgpJbnRvIGF0bWVsX2luaXRfc2xvdDoK bW1jLT5mX21pbiA9IERJVl9ST1VORF9VUChob3N0LT5idXNfaHosIDUxMik7Cm1tYy0+Zl9tYXgg PSBob3N0LT5idXNfaHogLyAyOwoKUmVnYXJkcwoKTHVkb3ZpYwoKPiBTbyB0aGlzIHdvdWxkIGJl IE9LLgo+Cj4gRG5lIDIwLjYuMjAxMiAxMToxMywgbHVkb3ZpYy5kZXNyb2NoZXMgbmFwc2FsKGEp Ogo+PiBBZGQgbW1jIG1haWxpbmcgbGlzdC4KPj4KPj4KPj4gLS0tLS0tLS0gTWVzc2FnZSBvcmln aW5hbCAtLS0tLS0tLQo+PiBTdWpldDogUmU6IFtQQVRDSF0gbW1jOiBhdDkxOiBmaXggYnVzIHNw ZWVkCj4+IERhdGUgOiBXZWQsIDIwIEp1biAyMDEyIDEwOjQ5OjA4ICswMjAwCj4+IERlIDogbHVk b3ZpYy5kZXNyb2NoZXMgPGx1ZG92aWMuZGVzcm9jaGVzQGF0bWVsLmNvbT4KPj4gUG91ciA6IFBy Y2hhbCBKacWZw60gPGppcmkucHJjaGFsQGFrc2lnbmFsLmN6Pgo+PiBDb3BpZSDDoCA6IDxsdWRv dmljLmRlc3JvY2hlc0BhdG1lbC5jb20+LAo+PiA8bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnPgo+Pgo+PiBIZWxsbyBKaXJpLAo+Pgo+PiBUaGFua3MgZm9yIHlvdXIgcGF0Y2gg YnV0IGF0OTEtbWNpIGlzIG5vdyBkZXByZWNhdGVkIGFuZCBzaG91bGQgYmUKPj4gcmVtb3ZlZCBp biAzLjcuCj4+IE9uIG9uZSBoYW5kIEkgZG9uJ3Qga25vdyBpZiB3ZSBoYXZlIHRvIGNvbnRpbnVl IHRvIHRha2UgcGF0Y2hlcyBmb3IgdGhpcwo+PiBkcml2ZXIsIG9uIHRoZSBvdGhlciBoYW5kIGl0 J3MgYSBmaXggZm9yIHNvbWUgU0QgY2FyZHMuCj4+Cj4+IExlIDA2LzIwLzIwMTIgMTA6MTUgQU0s IFByY2hhbCBKacWZw60gYSDDqWNyaXQgOgo+Pj4gVGhpcyBwYXRjaCBjaGFuZ2UgbWluaW11bSBh bmQgbWF4aW11bSBjbG9jayBzcGVlZCBiZWNhdXNlIHNvbWUgbm9uYW1lCj4+PiBjYXJkcyBkb2Vz bid0IHdvcmsgZHVyaW5nIGluaXQgZXZlbiBhdCAzNzVrSHogYW5kIG5ldyBjYXJkcyAoU0Qgdi4g My4wKQo+Pj4gY2FuIHJ1biBhdCA1MCBvciAxMDAgTUh6Lgo+Pj4gQWxzbyBhZGVkIGNsa2RpdiBy ZWdpc3RlciBvdmVycnVuIGZpeCB3aGVuIHNldHRpbmcgbG93IHNwZWVkcy4KPj4+Cj4+PiBTaWdu ZWQtb2ZmLWJ5OiBKaXJpIFByY2hhbCA8amlyaS5wcmNoYWxAYWtzaWduYWwuY3o+Cj4+PiAtLS0K Pj4+Cj4+PiAtLS0gbGludXgvbGludXgtMy41LXJjMy9kcml2ZXJzL21tYy9ob3N0L2F0OTFfbWNp LmMub3JpZyAyMDEyLTA2LTE3Cj4+PiAwMjoyNToxNy4wMDAwMDAwMDAgKzAyMDAKPj4+ICsrKyBs aW51eC9saW51eC0zLjUtcmMzL2RyaXZlcnMvbW1jL2hvc3QvYXQ5MV9tY2kuYyAyMDEyLTA2LTE4 Cj4+PiAxMTowMTo0OS43NTE0MTU5ODQgKzAyMDAKPj4+IEBAIC03MjQsNiArNzI0LDEwIEBAIHN0 YXRpYyB2b2lkIGF0OTFfbWNpX3NldF9pb3Moc3RydWN0IG1tY18KPj4+IGVsc2UKPj4+IGNsa2Rp diA9IChhdDkxX21hc3Rlcl9jbG9jayAvIGlvcy0+Y2xvY2spIC8gMjsKPj4+Cj4+PiArIC8qIHNl dCBtYXhpbXVtIGRpdmlkZXIgKi8KPj4+ICsgaWYgKGNsa2RpdiA+IDI1NSkKPj4+ICsgY2xrZGl2 ID0gMjU1Owo+Pj4gKwo+Pj4gcHJfZGVidWcoImNsa2RpdiA9ICVkLiBtY2NrID0gJWxkXG4iLCBj bGtkaXYsCj4+PiBhdDkxX21hc3Rlcl9jbG9jayAvICgyICogKGNsa2RpdiArIDEpKSk7Cj4+PiB9 Cj4+PiBAQCAtOTQ4LDggKzk1Miw4IEBAIHN0YXRpYyBpbnQgX19pbml0IGF0OTFfbWNpX3Byb2Jl KHN0cnVjdAo+Pj4gfQo+Pj4KPj4+IG1tYy0+b3BzID0gJmF0OTFfbWNpX29wczsKPj4+IC0gbW1j LT5mX21pbiA9IDM3NTAwMDsKPj4+IC0gbW1jLT5mX21heCA9IDI1MDAwMDAwOwo+Pj4gKyBtbWMt PmZfbWluID0gMjAwMDAwOyAvKiBub3QgYWxsIGNhcmRzIGNhbiBydW4gYXQgMzc1a0h6ICovCj4+ Cj4+IEkgd2lsbCBjaGVjayBvbiBhdG1lbC1tY2kgaWYgd2UgaGF2ZSB0byBkZWNyZWFzZSBmX21p bi4KPj4KPj4+ICsgbW1jLT5mX21heCA9IDEwMDAwMDAwMDsgLyogbmV3IGNhcmRzIGNhbiBydW4g YXQgMTAwTUh6ICovCj4+Cj4+IE1DSSBvcGVyYXRlcyBhdCBhIHJhdGUgb2YgdXAgdG8gbWFzdGVy IGNsb2NrIGRpdmlkZWQgYnkgdHdvIHNvIHlvdSBjYW4ndAo+PiByZWFjaCAxMDBNSHogYXMgbWF4 IGZyZXF1ZW5jeSBzaW5jZSBpdCBtZWFucyB0aGF0IG91ciBtYXN0ZXIgY2xvY2sgaXMgYXQKPj4g MjAwTUh6IHRoYXQgaXMgbm90IHRoZSBjYXNlLiBJIHdvdWxkIHNheSA1ME1IeiBpcyB0aGUgbWF4 aW11bSBmcmVxdWVuY3kKPj4gZm9yIHByb2R1Y3QgY29tcGF0aWJsZSB3aXRoIGF0OTEtbWNpLgo+ Pgo+Pj4gbW1jLT5vY3JfYXZhaWwgPSBNTUNfVkREXzMyXzMzIHwgTU1DX1ZERF8zM18zNDsKPj4+ IG1tYy0+Y2FwcyA9IDA7Cj4+Pgo+Pj4KPj4+Cj4+Cj4+IFJlZ2FyZHMKPj4KPj4gTHVkb3ZpYwo+ Pgo+Pgo+Pgo+Pgo+Pgo+Cj4KPgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludovic.desroches@atmel.com (ludovic.desroches) Date: Thu, 21 Jun 2012 10:23:41 +0200 Subject: Fwd: Re: [PATCH] mmc: at91: fix bus speed In-Reply-To: <4FE2D3A9.6000803@aksignal.cz> References: <4FE18E84.9000603@atmel.com> <4FE19423.4010103@atmel.com> <4FE2D3A9.6000803@aksignal.cz> Message-ID: <4FE2DA0D.2080509@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Prchal, Le 06/21/2012 09:56 AM, Prchal Ji?? a ?crit : > Hello Ludovic, > I have tried it with atmel-mci driver. It took me little time to change > setting of my board. > It seems to try clock down to 200kHz: > [ 5.860000] mmc0: mmc_rescan_try_freq: trying to init card at 400000 Hz > [ 5.920000] mmc0: mmc_rescan_try_freq: trying to init card at 300000 Hz > [ 5.980000] mmc0: mmc_rescan_try_freq: trying to init card at 205079 Hz > As I see in driver source, there is better clkdiv overrun work around. Yes it was well managed in this driver. > But I don't find min and max freq definitions in this driver, it is > probably somewhere else. Into atmel_init_slot: mmc->f_min = DIV_ROUND_UP(host->bus_hz, 512); mmc->f_max = host->bus_hz / 2; Regards Ludovic > So this would be OK. > > Dne 20.6.2012 11:13, ludovic.desroches napsal(a): >> Add mmc mailing list. >> >> >> -------- Message original -------- >> Sujet: Re: [PATCH] mmc: at91: fix bus speed >> Date : Wed, 20 Jun 2012 10:49:08 +0200 >> De : ludovic.desroches >> Pour : Prchal Ji?? >> Copie ? : , >> >> >> Hello Jiri, >> >> Thanks for your patch but at91-mci is now deprecated and should be >> removed in 3.7. >> On one hand I don't know if we have to continue to take patches for this >> driver, on the other hand it's a fix for some SD cards. >> >> Le 06/20/2012 10:15 AM, Prchal Ji?? a ?crit : >>> This patch change minimum and maximum clock speed because some noname >>> cards doesn't work during init even at 375kHz and new cards (SD v. 3.0) >>> can run at 50 or 100 MHz. >>> Also aded clkdiv register overrun fix when setting low speeds. >>> >>> Signed-off-by: Jiri Prchal >>> --- >>> >>> --- linux/linux-3.5-rc3/drivers/mmc/host/at91_mci.c.orig 2012-06-17 >>> 02:25:17.000000000 +0200 >>> +++ linux/linux-3.5-rc3/drivers/mmc/host/at91_mci.c 2012-06-18 >>> 11:01:49.751415984 +0200 >>> @@ -724,6 +724,10 @@ static void at91_mci_set_ios(struct mmc_ >>> else >>> clkdiv = (at91_master_clock / ios->clock) / 2; >>> >>> + /* set maximum divider */ >>> + if (clkdiv > 255) >>> + clkdiv = 255; >>> + >>> pr_debug("clkdiv = %d. mcck = %ld\n", clkdiv, >>> at91_master_clock / (2 * (clkdiv + 1))); >>> } >>> @@ -948,8 +952,8 @@ static int __init at91_mci_probe(struct >>> } >>> >>> mmc->ops = &at91_mci_ops; >>> - mmc->f_min = 375000; >>> - mmc->f_max = 25000000; >>> + mmc->f_min = 200000; /* not all cards can run at 375kHz */ >> >> I will check on atmel-mci if we have to decrease f_min. >> >>> + mmc->f_max = 100000000; /* new cards can run at 100MHz */ >> >> MCI operates at a rate of up to master clock divided by two so you can't >> reach 100MHz as max frequency since it means that our master clock is at >> 200MHz that is not the case. I would say 50MHz is the maximum frequency >> for product compatible with at91-mci. >> >>> mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34; >>> mmc->caps = 0; >>> >>> >>> >> >> Regards >> >> Ludovic >> >> >> >> >> > > >