From: Roger Pau Monne <roger.pau@citrix.com>
To: Matt Wilson <msw@amazon.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools: honour --libdir when it is passed to ./configure
Date: Thu, 21 Jun 2012 10:12:17 +0100 [thread overview]
Message-ID: <4FE2E571.5040505@citrix.com> (raw)
In-Reply-To: <20120620182742.GC2640@US-SEA-R8XVZTX>
Matt Wilson wrote:
> On Wed, Jun 20, 2012 at 09:44:13AM -0700, Wilson, Matt wrote:
>> On Wed, Jun 20, 2012 at 01:51:17AM -0700, Roger Pau Monne wrote:
>>> Matt Wilson wrote:
>>>> +CFLAGS += -Wno-unknown-pragmas -I$(XEN_ROOT)/tools/libfsimage/common/ -DFSIMAGE_FSDIR=\"$(FSDIR)\"
>>> I would prefer to set FSIMAGE_FSDIR or an equivalent define in
>>> tools/config.h and include that header in
>>> tools/libfsimage/common/fsimage_plugin.h, so we don't have to pass that
>>> value from the compiler command line.
>
> It turns out to be tricky to do this, since you have to recursively
> expand the value from libdir="${exec_prefix}/lib". Also, it's counter
> to the generally accepted pattern for passing these types of variables
> down when using autoconf, which actually is to use -D in CFLAGS.
>
> See also this thread:
> http://stackoverflow.com/questions/5867136/autoconf-how-to-get-installation-paths-into-config-h
Fair enough, thanks.
next prev parent reply other threads:[~2012-06-21 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 0:46 [PATCH] tools: honour --libdir when it is passed to ./configure Matt Wilson
2012-06-20 8:51 ` Roger Pau Monne
2012-06-20 16:44 ` Matt Wilson
2012-06-20 16:51 ` Ian Campbell
2012-06-20 18:27 ` Matt Wilson
2012-06-21 9:12 ` Roger Pau Monne [this message]
2012-06-20 9:10 ` Ian Campbell
2012-06-20 16:41 ` Matt Wilson
2012-06-20 16:44 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE2E571.5040505@citrix.com \
--to=roger.pau@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=msw@amazon.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.