Re: [PATCH] docs: block: update ioprio.txt

["gnehzuil.lzheng@gmail.com" <gnehzuil.lzheng@gmail.com>]

On 06/21/2012 12:50 PM, Rob Landley wrote:

> On 06/19/2012 05:27 AM, Zheng Liu wrote:
>> Hi Sami,
>>
>> [You forgot to CC'd other developers and mailing list]
>>
>> On Tue, Jun 19, 2012 at 10:54:41AM +0200, Sami Kerola wrote:
>>> Hi Zheng,
>>>
>>> Wouldn't a patch such as below be better?
>>
>> Looks good to me.  But, IMHO, if reader cannot access Internet, my patch
>> maybe is better for them.  The original writer is not me.  So I don't
>> understand the original idea that puts ionice source code in here.  I
>> think that Jens can do the final decision.
>>
>> Hi Jens,
>>
>> What's your opintion about Sami's and my patch?
> 
> I note that it's nice to have a reference implementation for nontrivial
> things. Also, util-linux isn't the end-all and be-all of linux
> userspace: busybox has an ionice, and I plan to add an ionice
> implementation to toybox as well.
> 
> So fixing reference code is good. That said, this isn't a "fix", this is
> a rewrite adding all sorts of unnecessary complexity
> (internationalization? strtos32_or_error() instead of strtol()?) that
> makes it much _less_ effective as reference code.


OK.  I will repost a second version later.

Regards,
Zheng