From: "Andreas Färber" <afaerber@suse.de>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] hw/Makefile.objs question
Date: Thu, 21 Jun 2012 12:36:02 +0200 [thread overview]
Message-ID: <4FE2F912.1080904@suse.de> (raw)
In-Reply-To: <4FE29366.6050101@ozlabs.ru>
Am 21.06.2012 05:22, schrieb Alexey Kardashevskiy:
> I am trying to compile the very last qemu with vfio_pci enabled. VFIO_PCI is added as below:
>
> ./configure:
>
> case "$target_arch2" in
> i386|x86_64|ppc64)
> if test "$vfio_pci" = "yes" -a "$target_softmmu" = "yes" ; then
> echo "CONFIG_VFIO_PCI=y" >> $config_target_mak
> fi
> esac
>
>
> ./Makefile.target:
>
> # VFIO PCI device assignment
> obj-$(CONFIG_VFIO_PCI) += vfio_pci.o
>
>
> And it worked before. However it does not anymore as it seems that everything in hw/ (and vfio_pci.c
> as well as is in hw/ and it is a device) can be only compiled via hw/Makefile.objs and
> hw/ppc/Makefile.objs (my platform is POWER), it is ignored if to keep it as is.
>
> So I have to move "obj-$(CONFIG_VFIO_PCI) += vfio_pci.o" to hw/Makefile.objs (and change obj- to
> hw-obj-) but the hw/Makefile.objs does not include (directly or indirectly) generated
> ppc64-softmmu/config-target.mak with CONFIG_VFIO_PCI=y.
>
> What is the correct solution?
If the file compiles the same for all three, put CONFIG_VFIO_PCI=y into
default-configs/{i386,x86_64,ppc64}-softmmu.mak and do
hw-obj-$(CONFIG_VFIO_PCI) += in hw/Makefile.objs.
Otherwise, add to hw/{i386,ppc}/Makefile.objs - or with Anthony's
proposal from yesterday hw/Makefile.objs becomes possible, too.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-06-21 10:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 3:22 [Qemu-devel] hw/Makefile.objs question Alexey Kardashevskiy
2012-06-21 10:36 ` Andreas Färber [this message]
2012-06-21 11:21 ` Alexey Kardashevskiy
2012-06-21 12:19 ` Andreas Färber
2012-06-21 13:10 ` Alexey Kardashevskiy
2012-06-21 13:23 ` Anthony Liguori
2012-06-21 14:04 ` Andreas Färber
2012-06-21 15:52 ` Alex Williamson
2012-06-22 2:23 ` Alexey Kardashevskiy
2012-07-02 10:36 ` Paolo Bonzini
2012-07-02 12:10 ` Andreas Färber
2012-07-02 12:10 ` Alexey Kardashevskiy
2012-07-02 12:11 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE2F912.1080904@suse.de \
--to=afaerber@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.