Re: [PATCH 2/2] iio:trigger: Use to_iio_trigger() instead of dev_get_drvdata()

[Jonathan Cameron <jic23@cam.ac.uk>]

On 6/18/2012 5:46 PM, Lars-Peter Clausen wrote:
> Use to_iio_trigger(dev) instead of dev_get_drvdata(dev). Both will return the
> trigger which belongs to the device, but the the first on is a bit more
> lightweight.
>
> Since this is the last location where we used dev_get_drvdata() for retrieving
> the trigger there is no need anymore to assign the the trigger to the devices
> drvdata, so we can remove that as well.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
>   drivers/iio/industrialio-trigger.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c
> index 0f582df..ec653fb 100644
> --- a/drivers/iio/industrialio-trigger.c
> +++ b/drivers/iio/industrialio-trigger.c
> @@ -45,7 +45,7 @@ static ssize_t iio_trigger_read_name(struct device *dev,
>   				     struct device_attribute *attr,
>   				     char *buf)
>   {
> -	struct iio_trigger *trig = dev_get_drvdata(dev);
> +	struct iio_trigger *trig = to_iio_trigger(dev);
>   	return sprintf(buf, "%s\n", trig->name);
>   }
>
> @@ -436,7 +436,6 @@ struct iio_trigger *iio_trigger_alloc(const char *fmt, ...)
>   		trig->dev.type = &iio_trig_type;
>   		trig->dev.bus = &iio_bus_type;
>   		device_initialize(&trig->dev);
> -		dev_set_drvdata(&trig->dev, (void *)trig);
>
>   		mutex_init(&trig->pool_lock);
>   		trig->subirq_base
>