From: Alejandro Cabrera <acabrera@udio.cujae.edu.cu>
To: Michal Simek <monstr@monstr.eu>
Cc: linux-watchdog@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
Wim Van Sebroeck <wim@iguana.be>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: xilinx: Read clock frequency directly from DT node
Date: Thu, 21 Jun 2012 14:04:09 -0500 [thread overview]
Message-ID: <4FE37029.50007@udio.cujae.edu.cu> (raw)
In-Reply-To: <1340261140-10166-1-git-send-email-monstr@monstr.eu>
> Do not use clock-frequency property from parent node.
> Use it from watchdog node.
>
> Signed-off-by: Michal Simek<monstr@monstr.eu>
Acked-By: Alejandro Cabrera <acabrera@udio.cujae.edu.cu>
> ---
> drivers/watchdog/of_xilinx_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
> index 55d2f66..294fb4e 100644
> --- a/drivers/watchdog/of_xilinx_wdt.c
> +++ b/drivers/watchdog/of_xilinx_wdt.c
> @@ -297,7 +297,7 @@ static int __devinit xwdt_probe(struct platform_device *pdev)
>
> no_timeout = 0;
>
> - pfreq = (u32 *)of_get_property(pdev->dev.of_node->parent,
> + pfreq = (u32 *)of_get_property(pdev->dev.of_node,
> "clock-frequency", NULL);
>
> if (pfreq == NULL) {
Participe en la XVI Convencion Cientifica de Ingenieria y Arquitectura del 26 al 30 de noviembre de 2012. La Habana, Cuba: http://ccia.cujae.edu.cu
Consulte la enciclopedia colaborativa cubana. http://www.ecured.cu
next prev parent reply other threads:[~2012-06-22 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 6:45 [PATCH] watchdog: xilinx: Read clock frequency directly from DT node Michal Simek
2012-06-21 19:04 ` Alejandro Cabrera [this message]
2012-06-26 19:10 ` Wim Van Sebroeck
2012-06-27 7:04 ` Michal Simek
2012-06-27 7:04 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE37029.50007@udio.cujae.edu.cu \
--to=acabrera@udio.cujae.edu.cu \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=rob.herring@calxeda.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.