Re: [PATCH 4/8] sanity.bbclass: warn the user if BBPATH contains wrong entries

[Scott Garman <scott.a.garman@intel.com>]

On 06/21/2012 08:51 AM, Khem Raj wrote:
> On Mon, Jun 18, 2012 at 12:56 PM, Scott Garman<scott.a.garman@intel.com>  wrote:
>> From: Laurentiu Palcu<laurentiu.palcu@intel.com>
>>
>> If BBPATH references the working directory, the user is warned and asked
>> to fix the problem.
>>
>> [Yocto #1465]
>>
>> (From OE-Core rev: 73f10ae955ba217078fa2c5288b736ae8a30b184)
>>
>> Signed-off-by: Laurentiu Palcu<laurentiu.palcu@intel.com>
>> Signed-off-by: Richard Purdie<richard.purdie@linuxfoundation.org>
>>
>> Reworked commit to fix merge conflicts with denzil branch.
>>
>> Signed-off-by: Scott Garman<scott.a.garman@intel.com>
>> ---
>>   meta/classes/sanity.bbclass |   13 ++++++++++++-
>>   1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
>> index 9755694..298372b 100644
>> --- a/meta/classes/sanity.bbclass
>> +++ b/meta/classes/sanity.bbclass
>> @@ -310,7 +310,18 @@ def check_sanity(sanity_data):
>>      if "." in data.getVar('PATH', sanity_data, True).split(":"):
>>          messages = messages + "PATH contains '.' which will break the build, please remove this"
>>
>> -    if data.getVar('TARGET_ARCH', sanity_data, True) == "arm":
>> +    bbpaths = sanity_data.getVar('BBPATH', True).split(":")
>> +    if "." in bbpaths or "" in bbpaths:
>> +        # TODO: change the following message to fatal when all BBPATH issues
>> +        # are fixed
>> +        bb.warn("BBPATH references the current directory, either through "    \
>> +                "an empty entry, or a '.'.\n\t This is unsafe and means your "\
>> +                "layer configuration is adding empty elements to BBPATH.\n\t "\
>> +                "Please check your layer.conf files and other BBPATH "        \
>> +                "settings to remove the current working directory "           \
>> +                "references.");
>> +
>> +    if sanity_data.getVar('TARGET_ARCH', True) == "arm":
>
> No I get this warning when I use OE-Core standalone. The reason is for OE-Core
>
> BBPATH .= ":${LAYERDIR}"
>
> and there are no more entries prepended since its the only layer so
> leading : is causing
> this warning to show up.
>
>>          # This path is no longer user-readable in modern (very recent) Linux
>>          try:
>>              if os.path.exists("/proc/sys/vm/mmap_min_addr"):
>> --
>> 1.7.9.5

Richard didn't end up pulling this in, and explained his reasoning on 
the oe-core ML. So no worries.

Scott

-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center