From: Bart Van Assche <bvanassche@acm.org>
To: linux-scsi <linux-scsi@vger.kernel.org>,
Babu Moger <babu.moger@netapp.com>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH] scsi_dh_alua: Re-enable STPG for unavailable ports
Date: Fri, 22 Jun 2012 08:49:38 +0000 [thread overview]
Message-ID: <4FE431A2.2050500@acm.org> (raw)
A quote from SPC-4: "While in the unavailable primary target port
asymmetric access state, the device server shall support those of
the following commands that it supports while in the active/optimized
state: [ ... ] d) SET TARGET PORT GROUPS; [ ... ]". Hence re-enable
sending STPG to a target port group that is in the unavailable state.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Babu Moger <babu.moger@netapp.com>
Cc: Hannes Reinecke <hare@suse.de>
---
This patch fixes a regression introduced in kernel 3.5-rc1.
---
drivers/scsi/device_handler/scsi_dh_alua.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 5088209..155fadc 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -691,9 +691,9 @@ static int alua_activate(struct scsi_device *sdev,
stpg = 0;
break;
case TPGS_STATE_STANDBY:
+ case TPGS_STATE_UNAVAILABLE:
stpg = 1;
break;
- case TPGS_STATE_UNAVAILABLE:
case TPGS_STATE_OFFLINE:
err = SCSI_DH_IO;
break;
next reply other threads:[~2012-06-22 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 8:49 Bart Van Assche [this message]
2012-06-22 17:52 ` [PATCH] scsi_dh_alua: Re-enable STPG for unavailable ports Moger, Babu
2012-06-22 18:50 ` Bart Van Assche
2012-06-22 20:05 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE431A2.2050500@acm.org \
--to=bvanassche@acm.org \
--cc=babu.moger@netapp.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.