From: Jan Schmidt <list.btrfs@jan-o-sch.net>
To: Josef Bacik <jbacik@fusionio.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Cc: "Chris L. Mason" <clmason@fusionio.com>
Subject: Re: Deadlock in ctree.c?
Date: Fri, 22 Jun 2012 16:26:56 +0200 [thread overview]
Message-ID: <4FE480B0.50201@jan-o-sch.net> (raw)
In-Reply-To: <4FE47FD6.9010205@fusionio.com>
On Fri, June 22, 2012 at 16:23 (+0200), Josef Bacik wrote:
> On 06/22/2012 09:38 AM, Jan Schmidt wrote:
>> On Fri, June 22, 2012 at 15:30 (+0200), Josef Bacik wrote:
>>> l2 shouldn't be locked anymore, if we're in push_leaf_left it's because we
>>> cow'ed l2 and are holding a lock on it, so really it has a lock on l2' and the
>>> btrfs_next_leaf is trying to get a lock on l2 which it should be free to do.
>>
>> Each tree block is cowed only once per transaction, right? Lets assume l2 was
>> cowed before any of the above threads started, we should end up with a lock on
>> l2 even in push_leaf_left, because should_cow_block returns 0.
>>
>
> Except you'd never get to l2 in the case that it had already been cow'ed. Thanks,
Thank you :-) That's the missing bit.
-Jan
prev parent reply other threads:[~2012-06-22 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 11:00 Deadlock in ctree.c? Jan Schmidt
2012-06-22 13:30 ` Josef Bacik
2012-06-22 13:38 ` Jan Schmidt
2012-06-22 14:23 ` Josef Bacik
2012-06-22 14:26 ` Jan Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE480B0.50201@jan-o-sch.net \
--to=list.btrfs@jan-o-sch.net \
--cc=clmason@fusionio.com \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.