All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	Prabhakar Lad <prabhakar.csengg@gmail.com>,
	linux-media@vger.kernel.org,
	Federico Vaga <federico.vaga@gmail.com>
Subject: Re: Recent patch for videobuf causing a crash to my driver
Date: Fri, 22 Jun 2012 11:51:13 -0300	[thread overview]
Message-ID: <4FE48661.9070307@redhat.com> (raw)
In-Reply-To: <2147318.3kAzv4eQOG@avalon>

Em 22-06-2012 05:50, Laurent Pinchart escreveu:
> Hi Hans,
> 
> On Friday 22 June 2012 09:50:44 Hans Verkuil wrote:
>> On 22/06/12 05:39, Prabhakar Lad wrote:
>>> Hi Federico,
>>>
>>> Recent patch from you (commit id a8f3c203e19b702fa5e8e83a9b6fb3c5a6d1cce4)
>>> which added cached buffer support to videobuf dma contig, is causing my
>>> driver to crash.
>>> Has this patch being tested for 'uncached' buffers ? If I replace this
>>> mapping logic with remap_pfn_range() my driver works without any crash.
>>>
>>> Or is that I am missing somewhere ?
>>
>> No, I had the same problem this week with vpif_capture. Since I was running
>> an unusual setup (a 3.0 kernel with the media subsystem patched to 3.5-rc1)
>> I didn't know whether it was caused by a mismatch between 3.0 and a 3.5
>> media subsystem.
>>
>> I intended to investigate this next week, but now it is clear that it is
>> this patch that is causing the problem.
> 
> Time to port the driver to videobuf2 ? ;-)

The regression needs to be fixed anyway, and send to stable. A patch that converts
it to VB2 won't met stable requirements.

Regards,
Mauro



  parent reply	other threads:[~2012-06-22 14:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22  3:39 Recent patch for videobuf causing a crash to my driver Prabhakar Lad
2012-06-22  7:50 ` Hans Verkuil
2012-06-22  8:50   ` Laurent Pinchart
2012-06-22  8:59     ` Hans Verkuil
2012-06-22  9:11       ` Prabhakar Lad
2012-06-22  9:28         ` Hans Verkuil
2012-06-22  9:45           ` Prabhakar Lad
2012-06-22 14:51     ` Mauro Carvalho Chehab [this message]
2012-06-22  9:09   ` Prabhakar Lad
2012-06-22  9:25     ` Hans Verkuil
2012-06-22 13:09 ` Federico Vaga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE48661.9070307@redhat.com \
    --to=mchehab@redhat.com \
    --cc=federico.vaga@gmail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.