All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] common/cmd_rsmode.c: add imx reset mode command
Date: Fri, 22 Jun 2012 11:04:27 -0500	[thread overview]
Message-ID: <4FE4978B.5010406@boundarydevices.com> (raw)
In-Reply-To: <20120621205711.05077202253@gemini.denx.de>

On 06/21/2012 03:57 PM, Wolfgang Denk wrote:
> Dear Eric Nelson,
>
> In message<4FCD17A5.6030705@boundarydevices.com>  you wrote:
>>
>>> The function of the watchdog should be reserved for auch systems who
>>> need it to implement security related functions; messing with it in
>>> unrelated places (like setting it into unexpected states and or
>>> timeouts) may cause undefined behaviour on such systems.
>>>
>>> Don't do it.
>>>
>>
>> My comment is that reset_cpu() should probably not return, and
>> at the moment it will. The minimum WDT timeout value is 1/2 second, so
>> execution will continue for some time less than that.
>>
>> It seems to me that this might be a bad thing, allowing unexpected
>> execution of commands in a script after the execution of the 'reset'
>> command.
>>
>> If I understand your comment, you're saying that reset_cpu() should
>> not be implemented using the watchdog.
>>
>> Is that right?
>
> No, that was not my intention.  I must have missed the fact that you
> were talking about reset_cpu() and only this function.  Please ignore
> me.
>

NP. I'll submit a patch to address the fact that the reset returns.

  reply	other threads:[~2012-06-22 16:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-26 21:01 [U-Boot] [PATCH 1/3] common/cmd_rsmode.c: add imx reset mode command Troy Kisky
2012-05-26 21:01 ` [U-Boot] [PATCH 2/3] mx6qsabrelite: select CONFIG_CMD_RSMODE Troy Kisky
2012-05-26 21:01 ` [U-Boot] [PATCH 3/3] mx53evk: " Troy Kisky
2012-05-27  6:04 ` [U-Boot] [PATCH 1/3] common/cmd_rsmode.c: add imx reset mode command Dirk Behme
2012-05-27 17:16   ` Eric Nelson
2012-05-28 17:36     ` Dirk Behme
2012-05-29 14:25       ` Eric Nelson
2012-06-04 19:52         ` Wolfgang Denk
2012-06-04 20:16           ` Eric Nelson
2012-06-21 20:57             ` Wolfgang Denk
2012-06-22 16:04               ` Eric Nelson [this message]
2012-07-11  6:32                 ` Dirk Behme
2012-07-11 18:01                   ` Troy Kisky
2012-07-11 18:44                     ` Dirk Behme
2012-05-27 17:33 ` Eric Nelson
2012-06-04 19:46 ` Wolfgang Denk
2012-06-04 20:43   ` Troy Kisky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE4978B.5010406@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.