All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: "Nikita V. Youshchenko" <nyoushchenko@mvista.com>
Cc: Rob Taylor <rtaylor@mvista.com>,
	Alexander Kaliadin <akaliadin@mvista.com>,
	linux-mtd@lists.infradead.org, Pavan Jadhav <pjadhav@mvista.com>
Subject: Re: ubi_update_fastmap: could not find an early PEB
Date: Fri, 22 Jun 2012 19:37:56 +0200	[thread overview]
Message-ID: <4FE4AD74.1040907@nod.at> (raw)
In-Reply-To: <201206222126.12515@blacky.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]

Hi!

Am 22.06.2012 19:26, schrieb Nikita V. Youshchenko:
> Where to get that?

git://git.kernel.org/pub/scm/linux/kernel/git/rw/ubi2.git ubi2/v12

In the meanwhile I had the chance to look closer at the issue.
The previously posted patch my help, but cannot help in all cases.
It can happen that a freshly created anchor (aka early) PEB will immediately
go into a fastmap pool, such that it cannot be used as fastmap super block.
I'll present a solution next week.

v12 has another issue.
If your flash contains bad PEBs the following WARN_ON() in fastmap.c will
spuriously trigger:

        /*
         * If fastmap is leaking PEBs (must not happen), raise a
         * fat warning and fall back to scanning mode.
         * We do this here because in ubi_wl_init() it's too late
         * and we cannot fall back to scanning.
         */
        if (WARN_ON(self_check_fastmap(ai) != ubi->peb_count -
                    ubi->bad_peb_count - used_blocks)) {
                ret = UBI_BAD_FASTMAP;
                kfree(fm);
                goto free_hdr;
        }


Instead of ubi->bad_peb_count it has to be ai->bad_peb_count.

Thanks,
//richard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2012-06-22 17:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-22 16:05 ubi_update_fastmap: could not find an early PEB Nikita V. Youshchenko
2012-06-22 16:32 ` Richard Weinberger
2012-06-22 17:26   ` Nikita V. Youshchenko
2012-06-22 17:37     ` Richard Weinberger [this message]
2012-06-22 18:46       ` Nikita V. Youshchenko
2012-06-22 18:49         ` Richard Weinberger
2012-06-27 10:56     ` Artem Bityutskiy
2012-06-27 11:00       ` Richard Weinberger
2012-06-27 11:07         ` Nikita V. Youshchenko
2012-06-27 12:15           ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE4AD74.1040907@nod.at \
    --to=richard@nod.at \
    --cc=akaliadin@mvista.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nyoushchenko@mvista.com \
    --cc=pjadhav@mvista.com \
    --cc=rtaylor@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.