From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH V2 3/3] core-image/misc: Added new IMAGE_FEATURE eclipse-support.
Date: Fri, 22 Jun 2012 11:09:49 -0700 [thread overview]
Message-ID: <4FE4B4ED.7000109@linux.intel.com> (raw)
In-Reply-To: <622f94dd940787bff2cf59299be285cfb6ddec98.1340166208.git.lianhao.lu@intel.com>
On 06/19/2012 09:25 PM, Lianhao Lu wrote:
> Added a new IMAGE_FEATURES eclipse-support to support developing user
> applications through Eclipse plugin.
>
Do we really need a new IMAGE_FEATURE? We already have tools-debug
which includes the tcf-agent, can we not just add the
openssh-sftp-server package to the task-core-tools-debug.bb? That would
work and not add yet another IMAGE_FEATURE.
Sau!
> Signed-off-by: Lianhao Lu<lianhao.lu@intel.com>
> ---
> meta/classes/core-image.bbclass | 2 ++
> meta/conf/multilib.conf | 1 +
> .../tasks/task-core-eclipse-support.bb | 17 +++++++++++++++++
> meta/recipes-sato/images/core-image-sato-sdk.bb | 2 +-
> 4 files changed, 21 insertions(+), 1 deletions(-)
> create mode 100644 meta/recipes-core/tasks/task-core-eclipse-support.bb
>
> diff --git a/meta/classes/core-image.bbclass b/meta/classes/core-image.bbclass
> index 6b207d7..8505d6f 100644
> --- a/meta/classes/core-image.bbclass
> +++ b/meta/classes/core-image.bbclass
> @@ -28,6 +28,7 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
> # - ssh-server-dropbear - SSH server (dropbear)
> # - ssh-server-openssh - SSH server (openssh)
> # - debug-tweaks - makes an image suitable for development
> +# - eclipse-support - Support Eclipse plugin
> #
> PACKAGE_GROUP_apps-console-core = "task-core-apps-console"
> PACKAGE_GROUP_x11-mini = "task-core-x11-mini"
> @@ -46,6 +47,7 @@ PACKAGE_GROUP_ssh-server-dropbear = "task-core-ssh-dropbear"
> PACKAGE_GROUP_ssh-server-openssh = "task-core-ssh-openssh"
> PACKAGE_GROUP_package-management = "${ROOTFS_PKGMANAGE}"
> PACKAGE_GROUP_qt4-pkgs = "task-core-qt-demos"
> +PACKAGE_GROUP_eclipse-support = "task-core-eclipse-support task-core-tools-debug task-core-tools-profile"
>
>
> # IMAGE_FEAETURES_REPLACES_foo = 'bar1 bar2'
> diff --git a/meta/conf/multilib.conf b/meta/conf/multilib.conf
> index cea8694..ee21d40 100644
> --- a/meta/conf/multilib.conf
> +++ b/meta/conf/multilib.conf
> @@ -618,6 +618,7 @@ BBCLASSEXTEND_append_pn-task-core-basic = " ${MULTILIBS}"
> BBCLASSEXTEND_append_pn-task-core-boot = " ${MULTILIBS}"
> BBCLASSEXTEND_append_pn-task-core-clutter = " ${MULTILIBS}"
> BBCLASSEXTEND_append_pn-task-core-console = " ${MULTILIBS}"
> +BBCLASSEXTEND_append_pn-task-core-eclipse-support = " ${MULTILIBS}"
> BBCLASSEXTEND_append_pn-task-core-gtk-directfb = " ${MULTILIBS}"
> BBCLASSEXTEND_append_pn-task-core-lsb = " ${MULTILIBS}"
> BBCLASSEXTEND_append_pn-task-core-nfs = " ${MULTILIBS}"
> diff --git a/meta/recipes-core/tasks/task-core-eclipse-support.bb b/meta/recipes-core/tasks/task-core-eclipse-support.bb
> new file mode 100644
> index 0000000..78a21a4
> --- /dev/null
> +++ b/meta/recipes-core/tasks/task-core-eclipse-support.bb
> @@ -0,0 +1,17 @@
> +DESCRIPTION = "Agent for Eclipse plugin task for Poky"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> + file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +PR = "r0"
> +
> +PACKAGES = "\
> + ${PN} \
> + ${PN}-dev \
> + ${PN}-dbg \
> + "
> +
> +ALLOW_EMPTY = "1"
> +
> +RDEPENDS_${PN} = "tcf-agent \
> + openssh-sftp-server \
> + "
> diff --git a/meta/recipes-sato/images/core-image-sato-sdk.bb b/meta/recipes-sato/images/core-image-sato-sdk.bb
> index 5bb9469..0630314 100644
> --- a/meta/recipes-sato/images/core-image-sato-sdk.bb
> +++ b/meta/recipes-sato/images/core-image-sato-sdk.bb
> @@ -5,7 +5,7 @@ DESCRIPTION = "Image with Sato support that includes everything within \
> core-image-sato plus meta-toolchain, development headers and libraries to \
> form a standalone SDK."
>
> -IMAGE_FEATURES += "apps-console-core ${SATO_IMAGE_FEATURES} dev-pkgs tools-sdk qt4-pkgs"
> +IMAGE_FEATURES += "apps-console-core ${SATO_IMAGE_FEATURES} dev-pkgs tools-sdk qt4-pkgs eclipse-support"
> EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
>
> SSHSERVER_IMAGE_FEATURES = "ssh-server-openssh"
prev parent reply other threads:[~2012-06-22 18:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 4:25 [PATCH V2 0/3] misc IMAGE_FEATURE fixings Lianhao Lu
2012-06-20 4:25 ` [PATCH V2 1/3] classes/image: Allow openssh empty passwords login Lianhao Lu
2012-06-20 4:25 ` [PATCH V2 2/3] image/core-image: Handle conflicting IMAGE_FEATURES Lianhao Lu
2012-06-20 4:25 ` [PATCH V2 3/3] core-image/misc: Added new IMAGE_FEATURE eclipse-support Lianhao Lu
2012-06-22 18:09 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE4B4ED.7000109@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.