From: Arjan van de Ven <arjan at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] conditionally disable pci support on ARM platforms
Date: Fri, 22 Jun 2012 13:01:10 -0700 [thread overview]
Message-ID: <4FE4CF06.9050903@linux.intel.com> (raw)
In-Reply-To: 1340390567-2994-1-git-send-email-rajagopal.venkat@linaro.org
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On 6/22/2012 11:42 AM, Rajagopal Venkat wrote:
> +case "$host" in
> +arm*)
> + AC_DEFINE([HAVE_NO_PCI],[1],[Define if host platform is ARM])
> + ;;
> +*)
> + PKG_CHECK_MODULES([PCIUTILS], [libpci],[],[
> + AC_SEARCH_LIBS([pci_get_dev], [pci], [], AC_MSG_ERROR([libpci is required but was not found]), [])
> + ])
> + ;;
> +esac
> +
I don't like this part.
if libpci is option, it is optional.
being arm or not is completely irrelevant in this regard.
(and there will undoubtedly ARM systems at some point that will have PCI
in them)
next reply other threads:[~2012-06-22 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 20:01 Arjan van de Ven [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-25 5:24 [Powertop] [PATCH] conditionally disable pci support on ARM platforms Rajagopal Venkat
2012-06-22 18:42 Rajagopal Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE4CF06.9050903@linux.intel.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.