From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?IlN1YmFzaCBQYXRlbCAo4LK44LOB4LKt4LK+4LK34LONKSI=?= Subject: Re: [PATCH] DRM: exynos: return NULL if exynos_pages_to_sg fails Date: Fri, 22 Jun 2012 17:54:20 -0700 Message-ID: <4FE513BC.2020008@gmail.com> References: <1340412060-22929-1-git-send-email-subash.ramaswamy@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pz0-f49.google.com (mail-pz0-f49.google.com [209.85.210.49]) by gabe.freedesktop.org (Postfix) with ESMTP id D647C9E874 for ; Fri, 22 Jun 2012 17:54:32 -0700 (PDT) Received: by dadm1 with SMTP id m1so3201801dad.36 for ; Fri, 22 Jun 2012 17:54:32 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Olof Johansson Cc: linaro-mm-sig@lists.linaro.org, Subash Patel , dri-devel@lists.freedesktop.org, inki.dae@samsung.com, subash.ramaswamy@linaro.org, airlied@redhat.com List-Id: dri-devel@lists.freedesktop.org Hi Olof, I will then rework this patch commit message and send it. I will copy Samsung-soc list (dri-devel is already in copy) Regards, Subash On 06/22/2012 05:47 PM, Olof Johansson wrote: > Hi, > > On Fri, Jun 22, 2012 at 5:41 PM, Subash Patel > wrote: > > From: Subash Patel > > > exynos_pages_to_sg() internally calls sg_kmalloc() which can return > no pages when the system is under high memory crunch. One such instance > is chromeos-install in the chromeos. This patch adds check for the > return > value of the function in subject to return NULL on failure. > > BUG=chrome-os-partner:9481 > TEST=built, ran on snow and tried chromeos-install without a crash > > Change-Id: I0abda74beaedae002a17de9962d7a462a2a7c2fb > Signed-off-by: Subash Patel > > > > No BUG/TEST/Change-Id on a public patch, please. Also, I didn't see this > posted on neither samsung-soc, nor the dri-devel list? > > > -Olof >