From: "Ruslan N. Marchenko" <me@ruff.mobi>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
BlueZ <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] pcm_bluetooth: accept BT_A2DP_SBC_SOURCE codec
Date: Sat, 23 Jun 2012 16:40:59 +0200 [thread overview]
Message-ID: <4FE5D57B.7090603@ruff.mobi> (raw)
In-Reply-To: <CABBYNZLKfMYfuk=N2qwh4skzffM5PT5hu5HXCPiZOZiAgdj=Eg@mail.gmail.com>
Hi Luiz Augusto,
Am 22.06.2012 22:34, schrieb Luiz Augusto von Dentz:
> Hi Ruslan,
>
> On Fri, Jun 22, 2012 at 1:49 PM, Ruslan N. Marchenko <me@ruff.mobi> wrote:
>> Current implementation of the PCM code is considering capture (source) mode
>> however it ignores codecs of the SBC_SOURCE type while parsing capabilities.
>> With these two lines source codec is accepted, although proper capture mode
>> might require additional changes.
>>
>> Signed-off-by: Ruslan N. Marchenko <me@ruff.mobi>
>> ---
>> audio/pcm_bluetooth.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
> We are about to remove alsa support from BlueZ as it doesn't support
> the Media API, so this is a nak
I see even trunk PA, mentioned [1] to be using Media API is using same
calls in the same ipc.c(bt_audio_service_open) - is it something still
to be cleaned up?
Anyway - does it make sense to port pcm_bluetooth to Media API
(media.c)? Or BlueZ team is going to abandon it in favour of PA in any
case? I mean if someone submit patches for pcm on Media API is there
chance for patches to be accepted?
1. -
http://lists.freedesktop.org/archives/pulseaudio-discuss/2011-November/012222.html
> Please next time use git format-patch + git send-email so it is easier
> to us to apply the patch using git am, also there is no need for the
> signed-off-by for userspace patches.
Thanks for tips, will follow.
--
Looking forward to reading yours...
Ruslan N. Marchenko
next prev parent reply other threads:[~2012-06-23 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 10:49 [PATCH] pcm_bluetooth: accept BT_A2DP_SBC_SOURCE codec Ruslan N. Marchenko
2012-06-22 20:34 ` Luiz Augusto von Dentz
2012-06-23 14:40 ` Ruslan N. Marchenko [this message]
2012-06-29 14:02 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE5D57B.7090603@ruff.mobi \
--to=me@ruff.mobi \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.