All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Budig <simon.budig@kernelconcepts.de>
To: linux-input@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, rydberg@euromail.se,
	olivier@sobrie.be, agust@denx.de, yanok@emcraft.com
Subject: Re: [PATCH v6] Touchscreen driver for FT5x06 based EDT displays
Date: Sun, 24 Jun 2012 14:31:16 +0200	[thread overview]
Message-ID: <4FE70894.6080908@kernelconcepts.de> (raw)
In-Reply-To: <1340408898-491-1-git-send-email-simon.budig@kernelconcepts.de>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/23/2012 01:48 AM, simon.budig@kernelconcepts.de wrote:
> This is a new iteration of the driver for the edt ft5x06 based 
> polytouch series of touchscreens. It contains most of the changes
> from Dmitry. I did not incorporate the attribute is_visible-stuff,
> since it did not work as expected for me. Also I do not release the
> reset pin.

I should add that this version might need a change in the registration
process in the board file, since it now uses the irq field of the i2c
entry instead of determining it from the irq-pin platform data.

So if your platform doesn't automatically configure the gpio pin when
requesting a gpio based IRQ you need to specify both for the driver to
configure it:

For my i.mx28 based board it looks like this:

static struct edt_ft5x06_platform_data edt_ft5x06_pdata = {
        .irq_pin = MXS_GPIO_NR(2, 5),
        .reset_pin = MXS_GPIO_NR(2, 6),
};

static struct i2c_board_info tx28_stk5v3_i2c_boardinfo[] __initdata = {
[...]
        {
                I2C_BOARD_INFO("edt-ft5x06", 0x38),
                .platform_data  = &edt_ft5x06_pdata,
                .irq = MXS_GPIO_IRQ_START + MXS_GPIO_NR(2, 5),
        },
};

I hope this helps.
         Simon

- -- 
       Simon Budig                        kernel concepts GmbH
       simon.budig@kernelconcepts.de      Sieghuetter Hauptweg 48
       +49-271-771091-17                  D-57072 Siegen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/nCJMACgkQO2O/RXesiHCvagCfSDx8+N3GSAVGTLhcHEcyIApB
X9wAn06iumsteC859PoDKcmyleopyJgZ
=RzlR
-----END PGP SIGNATURE-----

  parent reply	other threads:[~2012-06-24 12:31 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1326413229-30282-1-git-send-email-simon.budig@kernelconcepts.de>
2012-01-13  0:13 ` [PATCH v3] Touchscreen driver for FT5x06 based EDT displays simon.budig
2012-01-13  0:13   ` [PATCH] " simon.budig
2012-03-06 16:15   ` [PATCH v4] " simon.budig
2012-03-06 16:15     ` simon.budig
2012-03-07 10:42       ` Simon Budig
2012-03-07 13:36       ` Anatolij Gustschin
2012-03-07 14:50         ` Simon Budig
2012-04-04 18:27     ` [PATCH v5] " simon.budig
2012-04-04 18:27       ` [PATCH] " simon.budig
2012-04-04 19:10         ` Dmitry Torokhov
2012-04-04 20:52           ` Simon Budig
2012-04-04 21:09             ` Dmitry Torokhov
2012-04-05 10:27               ` Simon Budig
2012-04-05 12:54           ` Simon Budig
2012-05-07  6:57             ` Dmitry Torokhov
2012-06-22 23:48         ` [PATCH v6] " simon.budig
2012-06-22 23:48           ` simon.budig
2012-06-25  7:20             ` Dmitry Torokhov
2012-06-25  8:53               ` Henrik Rydberg
2012-06-25  8:51             ` Henrik Rydberg
2012-06-25  9:27               ` Simon Budig
2012-06-25 11:34                 ` Henrik Rydberg
2012-06-26  1:36                   ` Dmitry Torokhov
2012-06-26  5:37                 ` Olivier Sobrie
2012-06-26  2:06               ` Dmitry Torokhov
2012-06-26  9:06                 ` Simon Budig
2012-06-26 18:21                   ` Henrik Rydberg
2012-06-26 19:17                 ` Henrik Rydberg
2012-06-24 12:31           ` Simon Budig [this message]
2012-07-01 20:36           ` [PATCH v7] " simon.budig
2012-07-01 20:36             ` simon.budig
2012-07-02  9:31               ` Henrik Rydberg
2012-07-02  9:55                 ` Simon Budig
2012-07-08 16:05             ` [PATCH v8] " simon.budig
2012-07-08 16:05               ` simon.budig
2012-07-09  8:06                 ` Henrik Rydberg
2012-07-19  4:16                   ` Dmitry Torokhov
2012-07-19 13:50                     ` Henrik Rydberg
2012-07-19 13:56                       ` Simon Budig
2012-07-22 15:02               ` [PATCH v9] " simon.budig
2012-07-23 16:54                 ` Dmitry Torokhov
2012-07-23 17:45                   ` Henrik Rydberg
2012-07-24 20:06                     ` Simon Budig
2012-07-24 20:26                       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE70894.6080908@kernelconcepts.de \
    --to=simon.budig@kernelconcepts.de \
    --cc=agust@denx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=olivier@sobrie.be \
    --cc=rydberg@euromail.se \
    --cc=yanok@emcraft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.