All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] mtd-utils: do not stage headers in sysroot
Date: Sun, 24 Jun 2012 10:35:20 -0700	[thread overview]
Message-ID: <4FE74FD8.9000204@linux.intel.com> (raw)
In-Reply-To: <1340319423-24865-1-git-send-email-andrea.adami@gmail.com>

On 06/21/2012 03:57 PM, Andrea Adami wrote:
> * Headers are included in the package for compatibility
> * but have not yet been synched with linux 3.0
> * The actual issue was that ubi-user.h in sysroot
> * was overwritten by the older version.
> * Unfortunately one ioctl was renamed:
> * http://lists.infradead.org/pipermail/linux-mtd/
> * 2011-March/034419.html
> * Note: the recipe will still use its own older header,
> * following upstream.
>
> Signed-off-by: Andrea Adami<andrea.adami@gmail.com>
> ---
>   meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb |    6 +-----
>   1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
> index daa3554..1a9d4d3 100644
> --- a/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
> +++ b/meta/recipes-devtools/mtd/mtd-utils_1.5.0.bb
> @@ -11,16 +11,12 @@ SRC_URI = "git://git.infradead.org/mtd-utils.git;protocol=git;tag=ca39eb1d98e736
>
>   S = "${WORKDIR}/git/"
>
> -PR = "r0"
> +PR = "r1"
>
>   EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} -I${S}/include -DWITHOUT_XATTR' 'BUILDDIR=${S}'"
>
>   do_install () {
>   	oe_runmake install DESTDIR=${D} SBINDIR=${sbindir} MANDIR=${mandir} INCLUDEDIR=${includedir}
> -	install -d ${D}${includedir}/mtd/
> -	for f in ${S}/include/mtd/*.h; do
> -		install -m 0644 $f ${D}${includedir}/mtd/
> -	done
>   }
Just curious how this was tested?

I did a couple of different builds and on one clean rebuild, I found 
that udev failed because it could not find mtd/mtd-user.h

Thanks
	Sau!


>
>   PARALLEL_MAKE = ""



  reply	other threads:[~2012-06-24 17:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-21 22:57 [PATCH] mtd-utils: do not stage headers in sysroot Andrea Adami
2012-06-24 17:35 ` Saul Wold [this message]
2012-06-24 21:52   ` Andrea Adami
2012-06-25  5:29     ` Saul Wold
2012-06-25  5:31       ` Khem Raj
2012-06-28 17:10 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE74FD8.9000204@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.