From: Rajeev kumar <rajeev-dlh.kumar@st.com>
To: Devendra Naga <devendra.aaru@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Viresh Kumar <viresh.linux@gmail.com>,
spear-devel <spear-devel@list.st.com>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc/rtc-spear: remove unnecessary check against rtc_valid_tm and tm2bcd
Date: Mon, 25 Jun 2012 13:49:10 +0530 [thread overview]
Message-ID: <4FE81EFE.20000@st.com> (raw)
In-Reply-To: <1340451839-30623-1-git-send-email-devendra.aaru@gmail.com>
On 6/23/2012 5:13 PM, Devendra Naga wrote:
> rtc_valid_tm is always return
> -EINVAL if the time doesn't represent a valid date and time and 0 if its.
>
> so we can simply do rtc_valid_tm(tm) rather doing rtc_valid_tm(tm) != 0 checking.
> and also tm2bcd() does return -EINVAL if the time doesn't represent a valid date and time
> and 0 if its.
>
> and also removing err because is_write_complete will return -EIO if our write to the
> RTC registers didn't happen and 0 if its.
>
> Signed-off-by: Devendra Naga<devendra.aaru@gmail.com>
Acked-By: Rajeev Kumar <rajeev-dlh.kumar@st.com>
~Rajeev
prev parent reply other threads:[~2012-06-25 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 11:43 [PATCH] rtc/rtc-spear: remove unnecessary check against rtc_valid_tm and tm2bcd Devendra Naga
2012-06-25 8:18 ` viresh kumar
2012-06-26 9:34 ` devendra.aaru
2012-06-25 8:19 ` Rajeev kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE81EFE.20000@st.com \
--to=rajeev-dlh.kumar@st.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=devendra.aaru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=spear-devel@list.st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.