REG_EXTENDED (was Re: Release of 2.00~rc1)

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

On 24.06.2012 20:30, Vladimir 'φ-coder/phcoder' Serbinenko wrote:

> On 24.06.2012 09:29, Robert Mabee wrote:
> 
>> On 06/23/2012 04:59 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>> Hello, all. I'm proud to introduce 2.00~rc1 to you.
>>> It's available as
>>> ftp://alpha.gnu.org/gnu/grub/grub-2.00~rc1.tar.gz
>>> or
>>> ftp://alpha.gnu.org/gnu/grub/grub-2.00~rc1.tar.xz
>>> As far as I'm aware all issues have been either postponed or resolved
>>> correctly, so I'll release 2.00 on Monday. Give ~rc1 a spin over the
>>> weekend and report any issues.
>>>
>> Missed this one, where the symbol belongs to some other interface,
>> but has a value close enough to require an insane test (a filename
>> containing a newline) to get incorrect results:
>>
> 
> It wasn't presented as something that fixed any real issue but something
> that would be just cleaner. Dangerous cleanups aren't appropriate for
> freeze time. Please be more precise about the real issues.
> 

Please be more exact as to why this patch is needed.

>> === modified file 'grub-core/commands/wildcard.c'
>> --- old/grub-core/commands/wildcard.c 2012-06-08 20:54:21 +0000
>> +++ new/grub-core/commands/wildcard.c 2012-06-24 06:55:33 +0000
>> @@ -153,7 +153,7 @@
>> buffer[i] = '\0';
>> grub_dprintf ("expand", "Regexp is %s\n", buffer);
>>
>> - if (regcomp (regexp, buffer, RE_SYNTAX_GNU_AWK))
>> + if (regcomp (regexp, buffer, REG_EXTENDED))
>> {
>> grub_free (buffer);
>> return 1;
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
> 
> 
> 



-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]