All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: master - dev-io: open device read-only to obtain readahead value
Date: Mon, 25 Jun 2012 12:27:05 +0200	[thread overview]
Message-ID: <4FE83CF9.9010805@redhat.com> (raw)
In-Reply-To: <20120625095647.C465B1706@lists.fedorahosted.org>

Dne 25.6.2012 11:56, Peter Rajnoha napsal(a):
>
> dev-io: open device read-only to obtain readahead value
>
> There's no need to have the device open RW while obtaining the readahead value.
> The RW open used before caused the CHANGE udev event to be generated if the
> WATCH udev rule was set for the underlying device (and that is normally the
> case both for non-dm and dm devices by default).
>
> This did not cause any problems before since we were not interested in
> *underlying* devices. However, with upcoming changes (autoactivation), we're
> watching for events on underlying devices marked as PVs and such a spurious
> event could cause the autoactivation code to be triggered. So when trying
> to deactivate the volume, we could end up with immediate activation just after
> that because of the CHANGE event originated in the WATCH udev rule since the
> underlying device was open RW during the deactivation process.
>
> Though maybe a better solution would be to completely filter such spurious
> events out of the autoactivation process somehow, it's still useful if there
> are as least spurious events generated as possible in the system itself.


Which should be further fixed to use sysfs improved libdm method.

Zdenek



  reply	other threads:[~2012-06-25 10:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25  9:56 master - dev-io: open device read-only to obtain readahead value Peter Rajnoha
2012-06-25 10:27 ` Zdenek Kabelac [this message]
2012-06-25 10:39   ` Peter Rajnoha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE83CF9.9010805@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.