All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Tinguely <tinguely@sgi.com>
To: jeff.liu@oracle.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs: probe data buffer from page cache for unwritten extents
Date: Mon, 25 Jun 2012 11:13:05 -0500	[thread overview]
Message-ID: <4FE88E11.2050208@sgi.com> (raw)
In-Reply-To: <4FE85C7B.3010909@oracle.com>

On 06/25/12 07:41, Jeff Liu wrote:
> Hello,
>
> Using the start offset rather than map->br_startoff to calculate the starting page index could
> get more accurate data offset in page cache probe routine.
> With this refinement, the old max_t() could be able to remove too.
>
> Thanks Mark for pointing this out!
>
> -Jeff
>
>
> Cc: Mark Tinguely<tinguely@sgi.com>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>
> ---

> +			/*
> +			 * xfs_bmapi_read() can handle repeated hole regions,
> +			 * hence it should not return two extents both are
> +			 * holes.  If the 2nd extent is unwritten, there must
> +			 * have data buffer resides in page cache.
> +			 */
> +			BUG();


Looks great.

I hit the BUG() using a test with the following test:

  hole
  unwritten (treated as a hole)
  unwritten (treated as a hole)
  page of data.

I will send the current version of the test program.

--Mark.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-06-25 16:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 12:41 [PATCH v2] xfs: probe data buffer from page cache for unwritten extents Jeff Liu
2012-06-25 16:13 ` Mark Tinguely [this message]
2012-06-26  2:38 ` Dave Chinner
2012-06-26  6:45   ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE88E11.2050208@sgi.com \
    --to=tinguely@sgi.com \
    --cc=jeff.liu@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.