Re: [PATCH v4,1/5] MIPS: Add support for the 1074K core.

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 06/25/2012 07:09 PM, Steven J. Hill wrote:

> From: "Steven J. Hill" <sjhill@mips.com>

> Signed-off-by: Steven J. Hill <sjhill@mips.com>

    Minor nit on code formatting.

> diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
> index ce0dbee..b96ebe9 100644
> --- a/arch/mips/mm/c-r4k.c
> +++ b/arch/mips/mm/c-r4k.c
> @@ -1040,10 +1040,27 @@ static void __cpuinit probe_pcache(void)
>   	case CPU_R14000:
>   		break;
>
> +	case CPU_74K:
> +		/*
> +		 * Early versions of the 74k do not update
> +		 * the cache tags on a vtag miss/ptag hit
> +		 * which can occur in the case of KSEG0/KUSEG aliases
> +		 * In this case it is better to treat the cache as always
> +		 * having aliases
> +		 */
> +		if ((c->processor_id & 0xff) <= PRID_REV_ENCODE_332(2, 4, 0))
> +			c->dcache.flags |= MIPS_CACHE_VTAG;
> +		if ((c->processor_id & 0xff) == PRID_REV_ENCODE_332(2, 4, 0))
> +			write_c0_config6(read_c0_config6() | MIPS_CONF6_SYND);
> +		if (((c->processor_id & 0xff00) == PRID_IMP_1074K) &&
> +		   ((c->processor_id & 0xff) <= PRID_REV_ENCODE_332(1, 1, 0))) {

    Wrong indentation here -- the first ( should be shifted at least one space 
to the right.

WBR, Sergei