All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, jic23@cam.ac.uk
Subject: Re: [PATCH 2/7] iio staging: remove unused variable
Date: Mon, 25 Jun 2012 21:28:03 +0100	[thread overview]
Message-ID: <4FE8C9D3.8010703@kernel.org> (raw)
In-Reply-To: <1340651505-31081-2-git-send-email-pmeerw@pmeerw.net>

Missing sign off.

Just got the same warnings testing the previous patch as you
did so yup agreed with this one.  Do remember to add your sign off

Acked-by: Jonathan Cameron <jic23@kernel.org>

> ---
>  drivers/staging/iio/Documentation/generic_buffer.c |    2 --
>  drivers/staging/iio/Documentation/iio_utils.h      |    2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/Documentation/generic_buffer.c b/drivers/staging/iio/Documentation/generic_buffer.c
> index 8d6e91c..81358ac 100644
> --- a/drivers/staging/iio/Documentation/generic_buffer.c
> +++ b/drivers/staging/iio/Documentation/generic_buffer.c
> @@ -131,8 +131,6 @@ int main(int argc, char **argv)
>  
>  
>  	int ret, c, i, j, toread;
> -
> -	FILE *fp_ev;
>  	int fp;
>  
>  	int num_channels;
> diff --git a/drivers/staging/iio/Documentation/iio_utils.h b/drivers/staging/iio/Documentation/iio_utils.h
> index 6f3a392..6fe8540 100644
> --- a/drivers/staging/iio/Documentation/iio_utils.h
> +++ b/drivers/staging/iio/Documentation/iio_utils.h
> @@ -280,7 +280,7 @@ inline int build_channel_array(const char *device_dir,
>  {
>  	DIR *dp;
>  	FILE *sysfsfp;
> -	int count, temp, i;
> +	int count, i;
>  	struct iio_channel_info *current;
>  	int ret;
>  	const struct dirent *ent;
> 

  reply	other threads:[~2012-06-25 20:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 19:11 [PATCH 1/7] iio staging: fix generic_buffer print2byte() Peter Meerwald
2012-06-25 19:11 ` [PATCH 2/7] iio staging: remove unused variable Peter Meerwald
2012-06-25 20:28   ` Jonathan Cameron [this message]
2012-06-25 19:11 ` [PATCH 3/7] iio staging: move comment Peter Meerwald
2012-06-25 20:30   ` Jonathan Cameron
2012-06-25 19:11 ` [PATCH 4/7] iio staging: generic_buffer cleanup Peter Meerwald
2012-06-25 20:33   ` Jonathan Cameron
2012-06-25 19:11 ` [PATCH 5/7] iio staging: fix warning 'static but used in inline function' Peter Meerwald
2012-06-25 20:34   ` Jonathan Cameron
2012-06-25 19:11 ` [PATCH 6/7] iio staging: use PRId64 format specifier for int64_t Peter Meerwald
2012-06-25 20:37   ` Jonathan Cameron
2012-06-25 19:11 ` [PATCH 7/7] iio staging: quell asprintf() warning, missing #includes Peter Meerwald
2012-06-25 20:38   ` Jonathan Cameron
2012-06-25 20:23 ` [PATCH 1/7] iio staging: fix generic_buffer print2byte() Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2012-06-25 21:12 Peter Meerwald
2012-06-25 21:12 ` [PATCH 2/7] iio staging: remove unused variable Peter Meerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE8C9D3.8010703@kernel.org \
    --to=jic23@kernel.org \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.