From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SjLnf-0005Vm-Ku for mharc-grub-devel@gnu.org; Mon, 25 Jun 2012 22:46:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjLnd-0005V6-1W for grub-devel@gnu.org; Mon, 25 Jun 2012 22:46:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjLnb-0008VJ-3T for grub-devel@gnu.org; Mon, 25 Jun 2012 22:46:40 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:59161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjLna-0008V5-Mm for grub-devel@gnu.org; Mon, 25 Jun 2012 22:46:39 -0400 Received: by wgbds1 with SMTP id ds1so3290647wgb.30 for ; Mon, 25 Jun 2012 19:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=UMpLJjIBJoyZbjIGaHyGCE+dUoZKo5Ov9A3+C8JuR3I=; b=bnHRUoWl7PxgCM2YnIh/4ODCDh58RBFLVg1lmbcOkBaaSRb70EjgtS2vlzEHXLuvGg EVFJu6glqm3/3Qu9nNsGXJVlXq4w7EUH0TpdMaHwUYC+peWF9hxELCUyM+Ca16/w/p5i XlP31k1ajrPNZ5euNvKfMNjyNiC7TNjH2+5QX5zX82m8CN0rHcO+VS0i0MTwszGzZ2y8 B1JIbSZfkJ8+RJ2QXKvL7FBq+6PYCMJLgV5ZCrvsdtWwn2ymkbGX6/tg7c/ibBQOGYsh LoHP79vIs5vysY55YdQFV8AMrXUwhiKWgFYtkAMlyPT//C+aPW77C+0tHCD3DlTYc2qG 3eXg== Received: by 10.180.86.194 with SMTP id r2mr28748972wiz.15.1340678796383; Mon, 25 Jun 2012 19:46:36 -0700 (PDT) Received: from debian.x201.phnet (77-232.197-178.cust.bluewin.ch. [178.197.232.77]) by mx.google.com with ESMTPS id db7sm1553463wib.6.2012.06.25.19.46.35 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 25 Jun 2012 19:46:35 -0700 (PDT) Message-ID: <4FE9227A.3010808@gmail.com> Date: Tue, 26 Jun 2012 04:46:18 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120624 Icedove/10.0.5 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: Release of 2.00~rc1 References: <4FE62E30.7080608@gmail.com> <4FE6C1DF.9050000@comcast.net> <4FE8AC8F.4010806@gmail.com> <4FE91B67.104@comcast.net> In-Reply-To: <4FE91B67.104@comcast.net> X-Enigmail-Version: 1.4.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigC3A99E43E19759980A6D7F06" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2012 02:46:42 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC3A99E43E19759980A6D7F06 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 26.06.2012 04:16, Robert Mabee wrote: > On 06/25/2012 02:23 PM, Vladimir '=CF=86-coder/phcoder' Serbinenko wrot= e: >> On 24.06.2012 09:29, Robert Mabee wrote: >> >>> Missed this one, where the symbol belongs to some other interface, >>> but has a value close enough to require an insane test (a filename >>> containing a newline) to get incorrect results: >>> >>> =3D=3D=3D modified file 'grub-core/commands/wildcard.c' >>> --- old/grub-core/commands/wildcard.c 2012-06-08 20:54:21 +0000 >>> +++ new/grub-core/commands/wildcard.c 2012-06-24 06:55:33 +0000 >>> @@ -153,7 +153,7 @@ >>> buffer[i] =3D '\0'; >>> grub_dprintf ("expand", "Regexp is %s\n", buffer); >>> >>> - if (regcomp (regexp, buffer, RE_SYNTAX_GNU_AWK)) >>> + if (regcomp (regexp, buffer, REG_EXTENDED)) >>> { >>> grub_free (buffer); >>> return 1; >>> >> REG_EXTENDED isn't even a syntax type but is just refined to 1. Valid >> syntaxes are: >> >> RE_SYNTAX_EMACS >> RE_SYNTAX_AWK >> RE_SYNTAX_GNU_AWK =20 >> RE_SYNTAX_POSIX_AWK RE_SYNTAX_GREP >> RE_SYNTAX_EGREP =20 >> RE_SYNTAX_POSIX_EGREP RE_SYNTAX_ED >> RE_SYNTAX_SED >> RE_SYNTAX_POSIX_BASIC =20 >> RE_SYNTAX_POSIX_MINIMAL_BASIC =20 >> RE_SYNTAX_POSIX_EXTENDED =20 >> RE_SYNTAX_POSIX_MINIMAL_EXTENDED =20 >> >> Additionally no real testcase was ever demonstrated. > Looking at the code and "man regex" (not binding on Grub, but describes= > the code that was imported), it appears regcomp takes the OR of any of > REG_EXTENDED, REG_ICASE, REG_NEWLINE, REG_NOSUB, all defined by > POSIX. RE_SYNTAX_* are valid args to re_set_syntax or re_compile_intern= al, > defined by GNU. >=20 > RE_SYNTAX_GNU_AWK happens to have the bits REG_EXTENDED, REG_NEWLINE, > and REG_NOSUB set. The last has no effect because wildcard.c doesn't pa= ss > the array to collect subexpression matches. REG_EXTENDED is usually use= d > because the alternative ("basic") syntax is called obsolete. However, > the basic > syntax has many fewer special characters so would save code (to quote t= hem) > in wildcard.c. Probably REG_ICASE should be set according to the fs cas= e > insensitivity. >=20 > REG_NEWLINE causes incorrect results when a filename contains a newline= , > both because a wild char won't match the newline, and because the gener= ated > pattern anchors ^$ can match adjacent to the newline. Looks like you misinterpret the flags and it's actually reversed to what you say. Did you check that claimeed behaviour actuall occurs? REG_NEWLINE Match-any-character operators don't match a newline. A nonmatching list ([^...]) not containing a newline does not match a newline. Match-beginning-of-line operator (^) matches the empty string immediately after a newline, regardless of whether eflags, the execution flags of regexec(), con=E2=80=90 tains REG_NOTBOL. > For example, after > echo foo >'/foo > bar' > (shell, OS, fs permitting) Grub will fail to show this file with ls /f*= r > but will show > it with /*o or /b* (as well as the expected /*r and /f*). >=20 > I support your choice not to include this in a code freeze, since it is= > so unlikely > to affect anyone. I only wanted to make sure it didn't get lost. >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigC3A99E43E19759980A6D7F06 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk/pIoMACgkQNak7dOguQgkzlQD+PQicRcKXFLnvpONB+BfE5Nkm zFoz/vden9JG2cfS7MEA/jhjD9nvZjtPMdRBh6oPm38IS1pHXUrJlY6Rm/UmoziI =YftJ -----END PGP SIGNATURE----- --------------enigC3A99E43E19759980A6D7F06--