[ath9k-devel] [PATCH v3 04/10] ath9k_hw: advertise WoW support for capable chipsets

[Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>]

Hi Sujith,

On Monday 25 June 2012 10:54 PM, Sujith Manoharan wrote:
> Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>>
>> support WoW for all chipsets starting from AR9280, AR9285, AR9287,
>> AR9380, AR9382, AR9485, AR9462. Really all hardware may not support
>> WoW even though the flag is set and the WoW working depends on
>> your laptop, BIOS apart from the hardware.
>>
>> Cc: Senthil Balasubramanian<senthilb@qca.qualcomm.com>
>> Cc: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>> Cc: vadivel at qca.qualcomm.com
>> Signed-off-by: Luis R. Rodriguez<mcgrof@qca.qualcomm.com>
>> Signed-off-by: Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com>
>> ---
>>   drivers/net/wireless/ath/ath9k/hw.c |    8 ++++++++
>>   1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
>> index a42c26f..041d797 100644
>> --- a/drivers/net/wireless/ath/ath9k/hw.c
>> +++ b/drivers/net/wireless/ath/ath9k/hw.c
>> @@ -2572,6 +2572,14 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
>>   	}
>>
>>
>> +	if (AR_SREV_9280_20_OR_LATER(ah)) {
>> +		pCap->hw_caps |= ATH9K_HW_WOW_DEVICE_CAPABLE |
>> +				 ATH9K_HW_WOW_PATTERN_MATCH_EXACT;
>> +
>> +		if (AR_SREV_9280(ah))
>> +			pCap->hw_caps |= ATH9K_HW_WOW_PATTERN_MATCH_DWORD;
>> +	}
>> +
>
> I don't think this is a good idea - please enable WoW only for cards that
> we have actually tested.
>

I had tested it in quite a few of cards like AR9280, AR9285,AR9485 with 
wow enabled. Further the hardware was generic, with only quite a few 
changes needed between AR9002 and AR9003. thank you.

-- 
thanks,
shafi