From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Jonathan Cameron <jic23@cam.ac.uk>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio:dac:ad5064: Add support for the ad5629r and ad5669r
Date: Tue, 26 Jun 2012 10:24:25 +0200 [thread overview]
Message-ID: <4FE971B9.2040506@metafoo.de> (raw)
In-Reply-To: <4FE8C790.5020305@kernel.org>
>>[...]
>> +
>> +static const struct i2c_device_id ad5064_i2c_ids[] = {
>> + {"ad5629-1", ID_AD5628_1},
>> + {"ad5629-2", ID_AD5628_2},
>> + {"ad5629-3", ID_AD5628_2}, /* similar enough to ad5629-2 */
>> + {"ad5669-1", ID_AD5668_1},
>> + {"ad5669-2", ID_AD5668_2},
>> + {"ad5669-3", ID_AD5668_2}, /* similar enough to ad5669-2 */
> Must be null terminated.
>
> Btw I didn't get that by hand. Got a message at the end
> of build test
> drivers/iio/dac/ad5064: struct i2c_device_id is 24 bytes. The last of 6 is:
> 0x61 0x64 0x35 0x36 0x36 0x39 0x2d 0x33 0x00 0x00 0x00 0x00 0x00 0x00
> 0x00 0x00 0x00 0x00 0x00 0x00 0x0e 0x00 0x00 0x00
> FATAL: drivers/iio/dac/ad5064: struct i2c_device_id is not terminated
> with a NULL entry!
>
Damm, again... I never get this error on blackfin, I should really start
trying to compile drivers before submitting them on other archs as well.
Thanks.
prev parent reply other threads:[~2012-06-26 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 13:18 [PATCH] iio:dac:ad5064: Add support for the ad5629r and ad5669r Lars-Peter Clausen
2012-06-25 20:18 ` Jonathan Cameron
2012-06-26 8:24 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE971B9.2040506@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.