From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4FE9B6C2.7010006@tilera.com> Date: Tue, 26 Jun 2012 09:18:58 -0400 From: Chris Metcalf MIME-Version: 1.0 To: Myron Stowe CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 12/16] tile/PCI: Factor 'pcibios_setup()' out of tile References: <20120626033045.16434.17412.stgit@amt.stowe> <20120626033218.16434.50584.stgit@amt.stowe> In-Reply-To: <20120626033218.16434.50584.stgit@amt.stowe> Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: On 6/25/2012 11:32 PM, Myron Stowe wrote: > The PCI core provides a generic (__weak) 'pcibios_setup()' routine > that can be used by all architectures as a default. Drop tile's > architecture specific version in favor of that as it does not need to be > over-ridden. > > Signed-off-by: Myron Stowe > --- > > arch/tile/kernel/pci.c | 10 ---------- > 1 files changed, 0 insertions(+), 10 deletions(-) Acked-by: Chris Metcalf In our internal tree we have x86-like support for "pci=off" here. When I push that I can just push it as a new function to override the removed one, so I'm happy with your change as proposed. But perhaps it would make sense to move the support for "pci=off" to common code, since multiple architectures handle this the same way? -- Chris Metcalf, Tilera Corp. http://www.tilera.com