From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH 06/11] memcg: kmem controller infrastructure Date: Tue, 26 Jun 2012 19:01:15 +0400 Message-ID: <4FE9CEBB.80108@parallels.com> References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-7-git-send-email-glommer@parallels.com> <20120625161720.ae13ae90.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120625161720.ae13ae90.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Andrew Morton Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org, Tejun Heo , Pekka Enberg On 06/26/2012 03:17 AM, Andrew Morton wrote: >> + memcg_uncharge_kmem(memcg, size); >> >+ mem_cgroup_put(memcg); >> >+} >> >+EXPORT_SYMBOL(__mem_cgroup_free_kmem_page); >> > #endif /* CONFIG_CGROUP_MEM_RES_CTLR_KMEM */ >> > >> > #if defined(CONFIG_INET) && defined(CONFIG_CGROUP_MEM_RES_CTLR_KMEM) >> >@@ -5645,3 +5751,69 @@ static int __init enable_swap_account(char *s) >> > __setup("swapaccount=", enable_swap_account); >> > >> > #endif >> >+ >> >+#ifdef CONFIG_CGROUP_MEM_RES_CTLR_KMEM > gargh. CONFIG_MEMCG_KMEM, please! > Here too. I like it as much as you do. But that is consistent with the rest of the file, and I'd rather have it this way. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx179.postini.com [74.125.245.179]) by kanga.kvack.org (Postfix) with SMTP id 9A58A6B005A for ; Tue, 26 Jun 2012 11:03:58 -0400 (EDT) Message-ID: <4FE9CEBB.80108@parallels.com> Date: Tue, 26 Jun 2012 19:01:15 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH 06/11] memcg: kmem controller infrastructure References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-7-git-send-email-glommer@parallels.com> <20120625161720.ae13ae90.akpm@linux-foundation.org> In-Reply-To: <20120625161720.ae13ae90.akpm@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Pekka Enberg On 06/26/2012 03:17 AM, Andrew Morton wrote: >> + memcg_uncharge_kmem(memcg, size); >> >+ mem_cgroup_put(memcg); >> >+} >> >+EXPORT_SYMBOL(__mem_cgroup_free_kmem_page); >> > #endif /* CONFIG_CGROUP_MEM_RES_CTLR_KMEM */ >> > >> > #if defined(CONFIG_INET) && defined(CONFIG_CGROUP_MEM_RES_CTLR_KMEM) >> >@@ -5645,3 +5751,69 @@ static int __init enable_swap_account(char *s) >> > __setup("swapaccount=", enable_swap_account); >> > >> > #endif >> >+ >> >+#ifdef CONFIG_CGROUP_MEM_RES_CTLR_KMEM > gargh. CONFIG_MEMCG_KMEM, please! > Here too. I like it as much as you do. But that is consistent with the rest of the file, and I'd rather have it this way. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932071Ab2FZPEB (ORCPT ); Tue, 26 Jun 2012 11:04:01 -0400 Received: from mx2.parallels.com ([64.131.90.16]:36395 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757508Ab2FZPD7 (ORCPT ); Tue, 26 Jun 2012 11:03:59 -0400 Message-ID: <4FE9CEBB.80108@parallels.com> Date: Tue, 26 Jun 2012 19:01:15 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Andrew Morton CC: , , , Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , , , Tejun Heo , Pekka Enberg Subject: Re: [PATCH 06/11] memcg: kmem controller infrastructure References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-7-git-send-email-glommer@parallels.com> <20120625161720.ae13ae90.akpm@linux-foundation.org> In-Reply-To: <20120625161720.ae13ae90.akpm@linux-foundation.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/26/2012 03:17 AM, Andrew Morton wrote: >> + memcg_uncharge_kmem(memcg, size); >> >+ mem_cgroup_put(memcg); >> >+} >> >+EXPORT_SYMBOL(__mem_cgroup_free_kmem_page); >> > #endif /* CONFIG_CGROUP_MEM_RES_CTLR_KMEM */ >> > >> > #if defined(CONFIG_INET) && defined(CONFIG_CGROUP_MEM_RES_CTLR_KMEM) >> >@@ -5645,3 +5751,69 @@ static int __init enable_swap_account(char *s) >> > __setup("swapaccount=", enable_swap_account); >> > >> > #endif >> >+ >> >+#ifdef CONFIG_CGROUP_MEM_RES_CTLR_KMEM > gargh. CONFIG_MEMCG_KMEM, please! > Here too. I like it as much as you do. But that is consistent with the rest of the file, and I'd rather have it this way.