All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/3] autoconf: correctly parse *_INCLUDES and	*_LIB env vars
Date: Tue, 26 Jun 2012 17:32:41 +0100	[thread overview]
Message-ID: <4FE9E429.4040105@citrix.com> (raw)
In-Reply-To: <4FD72FD2.3040008@citrix.com>

Roger Pau Monne wrote:
> Ian Jackson wrote:
>> Roger Pau Monne writes ("[Xen-devel] [PATCH 3/3] autoconf: correctly parse *_INCLUDES and *_LIB env vars"):
>>> Parse those options correctly, since the "+=" operator is not valid.
>>> Also added CPPFLAGS, so headers checks don't give strange results.
>> ...
>>>    CFLAGS="$PREPEND_CFLAGS $CFLAGS $APPEND_CFLAGS"
>>> +CPPFLAGS="$CFLAGS"
>
> Without this I get the following (harmless but noisy) error:
>
> checking yajl/yajl_version.h usability... yes
> checking yajl/yajl_version.h presence... no
> configure: WARNING: yajl/yajl_version.h: accepted by the compiler,
> rejected by the preprocessor!
> configure: WARNING: yajl/yajl_version.h: proceeding with the compiler's
> result
>
>> Surely that can't be right.
>
>    From http://www.edwardrosten.com/code/autoconf/:
>
> "Just append stuff to CFLAGS (for the C compiler), CPPFLAGS (for the C
> preprocessor, C and C++ compilers), CXXFLAGS (for the C++ compiler) and
> LIBS (for the linker)."
>
> It seems like the preprocessor check uses CPPFLAGS instead of CFLAGS, so
> we have to set both.

Any news on this one?

Thanks, Roger.

      reply	other threads:[~2012-06-26 16:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 14:13 [PATCH 0/3] Minor fixes to the build system for NetBSD Roger Pau Monne
2012-05-11 14:13 ` [PATCH 1/3] autoconf/python_dev: pass include and library dir based on prefix Roger Pau Monne
2012-05-11 16:32   ` Ian Jackson
2012-05-14  9:51     ` Roger Pau Monne
2012-05-14 14:08       ` Ian Jackson
2012-05-11 14:13 ` [PATCH 2/3] build/tools: disable libvchan build on NetBSD Roger Pau Monne
2012-05-16 15:35   ` Christoph Egger
2012-06-08 15:22     ` Ian Jackson
2012-06-18 10:08       ` Roger Pau Monne
2012-06-18 10:38         ` Christoph Egger
2012-06-18 10:46         ` Roger Pau Monne
2012-05-11 14:13 ` [PATCH 3/3] autoconf: correctly parse *_INCLUDES and *_LIB env vars Roger Pau Monne
2012-06-08 15:22   ` Ian Jackson
2012-06-12 12:02     ` Roger Pau Monne
2012-06-26 16:32       ` Roger Pau Monne [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE9E429.4040105@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.