From: Richard Weinberger <richard@nod.at>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Joel Reardon <joel@clambassador.com>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 13/21] UBI: Fastmap: Introduce WL pool Signed-off-by: Richard Weinberger <richard@nod.at>
Date: Wed, 27 Jun 2012 10:20:58 +0200 [thread overview]
Message-ID: <4FEAC26A.4020708@nod.at> (raw)
In-Reply-To: <1340770405.2317.10.camel@koala>
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]
Am 27.06.2012 06:13, schrieb Artem Bityutskiy:
> On Wed, 2012-06-13 at 12:42 +0200, Richard Weinberger wrote:
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/mtd/ubi/build.c | 4 ++
>> drivers/mtd/ubi/fastmap.c | 51 ++++++++++++++++----------
>> drivers/mtd/ubi/ubi-media.h | 2 +
>> drivers/mtd/ubi/ubi.h | 1 +
>> drivers/mtd/ubi/wl.c | 82 ++++++++++++++++++++++++++++++++++++++----
>> 5 files changed, 112 insertions(+), 28 deletions(-)
>
> Hi, I've rebased the fastmap branch against v3.5-rc4, and your patches
> do not apply cleanly anymore, because there are collisions with Joel's
> changes which were merged recently. I've applied everything up to this
> patch and pushed out. Could you please re-base and re-send your queue?
> Thanks!
>
I'm confused.
schedule_erase() needs now vol_id and lnum as parameters but
the erase worker does not use them at all.
Am I missing something?
Fastmap is using schedule_erase() in ubi_wl_put_fm_peb() too,
but ubi_wl_put_fm_peb() does not know anything about volume IDs or
LEBs.
It's used to return PEBs used by fastmap itself.
Fastmap's volume headers have always lnum = 0 and
vol_id = UBI_FM_SB_VOLUME_ID or UBI_FM_DATA_VOLUME_ID.
Is this a problem?
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-06-27 8:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 10:41 UBI Fastmap updates (v7++) Richard Weinberger
2012-06-13 10:41 ` [PATCH 01/21] UBI: Fastmap: enhance find_early_wl_entry() Richard Weinberger
2012-06-13 10:41 ` [PATCH 02/21] UBI: Fastmap: Add PEB leak detection Richard Weinberger
2012-06-13 10:42 ` [PATCH 03/21] UBI: Fastmap: Remove useless code Richard Weinberger
2012-06-13 10:42 ` [PATCH 04/21] UBI: Fastmap: Check for duplicated PEBs in add_aeb() Richard Weinberger
2012-06-13 10:42 ` [PATCH 05/21] UBI: Fastmap: Rewrite scan_pool() Richard Weinberger
2012-06-13 10:42 ` [PATCH 06/21] UBI: Fastmap: Ensure that new_fm->e[0]->ec is always set Richard Weinberger
2012-06-13 10:42 ` [PATCH 07/21] UBI: Fastmap: Prevent PEB leak Richard Weinberger
2012-06-13 10:42 ` [PATCH 08/21] UBI: Fastmap: Add scrub support to add_aeb() Richard Weinberger
2012-06-13 10:42 ` [PATCH 09/21] UBI: Fastmap: Make ubi_wl_get_fm_peb() return a ubi_wl_entry Richard Weinberger
2012-06-13 10:42 ` [PATCH 10/21] UBI: Fastmap: Detect whether a PEB has to be unmapped Richard Weinberger
2012-06-13 10:42 ` [PATCH 11/21] UBI: Fastmap: Adjust comment above ubi_wl_flush() Richard Weinberger
2012-06-13 10:42 ` [PATCH 12/21] UBI: Fastmap: Handle unused "used" PEBs better Richard Weinberger
2012-06-13 10:42 ` [PATCH 13/21] UBI: Fastmap: Introduce WL pool Signed-off-by: Richard Weinberger <richard@nod.at> Richard Weinberger
2012-06-27 4:13 ` Artem Bityutskiy
2012-06-27 8:20 ` Richard Weinberger [this message]
2012-06-27 8:30 ` Artem Bityutskiy
2012-06-13 10:42 ` [PATCH 14/21] UBI: Fastmap: Erase PEBs synchronous in wear_leveling_worker() Richard Weinberger
2012-06-13 10:42 ` [PATCH 15/21] UBI: Fastmap: Fix NULL-pointer bug Richard Weinberger
2012-06-13 10:42 ` [PATCH 16/21] UBI: Fastmap: Fix loglevel Richard Weinberger
2012-06-13 10:42 ` [PATCH 17/21] UBI: Fastmap: Relax EC self check Richard Weinberger
2012-06-13 10:42 ` [PATCH 18/21] UBI: Fastmap: Store magic values in be32 Richard Weinberger
2012-06-13 10:42 ` [PATCH 19/21] UBI: Fastmap: Minor fixes Richard Weinberger
2012-06-13 10:42 ` [PATCH 20/21] UBI: Fastmap: Torture fastmap PEBs that showed bit flips Richard Weinberger
2012-06-13 10:42 ` [PATCH 21/21] UBI: Fastmap: make checkpatch.pl happy Signed-off-by: Richard Weinberger <richard@nod.at> Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEAC26A.4020708@nod.at \
--to=richard@nod.at \
--cc=dedekind1@gmail.com \
--cc=joel@clambassador.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.