From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.nokia.com ([147.243.1.47]:31969 "EHLO mgw-sa01.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753686Ab2F0L7e (ORCPT ); Wed, 27 Jun 2012 07:59:34 -0400 Message-ID: <4FEAF593.5060204@iki.fi> Date: Wed, 27 Jun 2012 14:59:15 +0300 From: Sakari Ailus MIME-Version: 1.0 To: Laurent Pinchart CC: linux-media@vger.kernel.org, Enrico , Jean-Philippe Francois , Abhishek Reddy Kondaveeti , Gary Thomas , Javier Martinez Canillas Subject: Re: [PATCH 1/6] omap3isp: video: Split format info bpp field into width and bpp References: <1340718339-29915-1-git-send-email-laurent.pinchart@ideasonboard.com> <1340718339-29915-2-git-send-email-laurent.pinchart@ideasonboard.com> <4FEAE987.6060104@iki.fi> <3151444.lq5j8qGhle@avalon> In-Reply-To: <3151444.lq5j8qGhle@avalon> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Laurent Pinchart wrote: > Hi Sakari, > > Thanks for the review. > > On Wednesday 27 June 2012 14:07:51 Sakari Ailus wrote: >> Laurent Pinchart wrote: >>> The bpp field currently stores the sample width and is aligned to the >>> next multiple of 8 bits when computing data size in memory. This won't >>> work anymore for YUYV8_2X8 formats. Split the bpp field into a sample >>> width and a bits per pixel value. >>> >>> Signed-off-by: Laurent Pinchart >> >> ... >> >>> diff --git a/drivers/media/video/omap3isp/ispvideo.h >>> b/drivers/media/video/omap3isp/ispvideo.h index 5acc909..f8092cc 100644 >>> --- a/drivers/media/video/omap3isp/ispvideo.h >>> +++ b/drivers/media/video/omap3isp/ispvideo.h >>> @@ -51,7 +51,8 @@ struct v4l2_pix_format; >>> >>> * @flavor: V4L2 media bus format code for the same pixel layout but >>> * shifted to be 8 bits per pixel. =0 if format is not shiftable. >>> * @pixelformat: V4L2 pixel format FCC identifier >>> >>> - * @bpp: Bits per pixel >>> + * @width: Data bus width >>> + * @bpp: Bits per pixel (when stored in memory) >> >> Would it make sense to use bytes rather than bits? > > I'll change that. > >> Also width isn't really the width of the data bus on serial busses, is it? >> How about busses that transfer pixels 8 bits at the time? > > I could change the comment to "bits per pixel (when transferred on a bus)", > would that be better ? Pixels (or samples, as you suggested later) sounds good to me. >> You can also stop using ALIGN() in isp_video_mbus_to_pix() (in ispvideo.c) >> as the ISP will always write complete bytes. > > Indeed. With these changes, Acked-by: Sakari Ailus -- Sakari Ailus sakari.ailus@iki.fi