From: Stephen Boyd <sboyd@codeaurora.org>
To: jonghwa3.lee@samsung.com
Cc: Jamie Iles <jamie@jamieiles.com>,
linux-kernel@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.hengli.com.au>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v2] Exynos : Add support for Exynos random number generator
Date: Wed, 27 Jun 2012 10:27:21 -0700 [thread overview]
Message-ID: <4FEB4279.2020701@codeaurora.org> (raw)
In-Reply-To: <4FEAECCE.3050006@samsung.com>
On 06/27/12 04:21, jonghwa3.lee@samsung.com wrote:
> On 2012년 06월 27일 20:07, Jamie Iles wrote:
>> A minor nit, but
>>
>> while (!(exynos_rng_readl(exynos_rng, EXYNOS_PRNG_STATUS_OFFSET) &
>> PRNG_DONE))
>> cpu_relax();
>>
>> would be a bit more conventional.
>>
>
> Stephen Boyd suggested to me that way. Anyway I'll follow with
> conventional way.
I was thinking
do {
status = exynos_rng_readl(exynos_rng, EXYNOS_PRNG_STATUS_OFFSET);
} while (!(status & PRNG_DONE));
But that works too.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-06-27 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 10:31 [PATCH v2] Exynos : Add support for Exynos random number generator Jonghwa Lee
2012-06-27 11:07 ` Jamie Iles
2012-06-27 11:21 ` jonghwa3.lee
2012-06-27 11:29 ` Jamie Iles
2012-06-27 17:27 ` Stephen Boyd [this message]
2012-06-27 17:52 ` Stephen Boyd
2012-06-28 0:20 ` jonghwa3.lee
2012-06-28 0:58 ` jonghwa3.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEB4279.2020701@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Julia.Lawall@lip6.fr \
--cc=herbert@gondor.hengli.com.au \
--cc=jamie@jamieiles.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.