From: Lars-Peter Clausen <lars@metafoo.de>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver
Date: Wed, 27 Jun 2012 22:56:25 +0200 [thread overview]
Message-ID: <4FEB7379.8040102@metafoo.de> (raw)
In-Reply-To: <8882387.r1uUUpi6dA@avalon>
On 06/27/2012 10:27 PM, Laurent Pinchart wrote:
> Hi Lars-Peter,
>
> On Wednesday 27 June 2012 22:06:54 Lars-Peter Clausen wrote:
>> On 06/27/2012 02:40 PM, Laurent Pinchart wrote:
>>> Hi Lars-Peter,
>>>
>>> [...]
>>>
>>> Do you plan to post a v3 of your "DRM: Add DRM kms/fb cma helper" patch in
>>> the near future ?
>>
>> Hi Laurent,
>>
>> I don't think there have been any changes since v2 except for adjusting to
>> the renamed functions in Sascha's patch. I'll send a v3 tomorrow.
>
> OK, thanks.
>
> As Ville pointed out, we need to validate the offsets and make sure the frame
> buffer fits in the GEM object(s). I don't think there's code in your patch to
> do so, have you thought about where/how to implement that ?
I think part of it needs to be done in the driver code, since the the generic
code does not the specific buffer layout requirements imposed by the hardware.
We can probably add some basic sanity checks for the buffer size though.
- Lars
next prev parent reply other threads:[~2012-06-27 20:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 12:32 [PATCH 0/4] Renesas SH Mobile DRM driver Laurent Pinchart
2012-05-30 12:32 ` [PATCH 1/4] fbdev: sh_mobile_meram: Add MERAM operations wrappers Laurent Pinchart
2012-05-30 12:32 ` [PATCH 2/4] fbdev: sh_mobile_lcdc: Use " Laurent Pinchart
2012-05-30 12:32 ` [PATCH 3/4] drm: Add NV24 and NV42 pixel formats Laurent Pinchart
2012-05-30 13:09 ` Ville Syrjälä
2012-05-30 13:20 ` Laurent Pinchart
2012-05-30 14:05 ` Ville Syrjälä
2012-05-30 14:09 ` Laurent Pinchart
2012-05-30 12:32 ` [PATCH 4/4] drm: Renesas SH Mobile DRM driver Laurent Pinchart
2012-05-30 13:43 ` Sascha Hauer
2012-05-30 13:48 ` Lars-Peter Clausen
2012-05-30 14:12 ` Laurent Pinchart
2012-05-30 14:16 ` Ville Syrjälä
2012-06-27 12:40 ` Laurent Pinchart
2012-05-30 14:45 ` Lars-Peter Clausen
2012-05-30 15:10 ` Lars-Peter Clausen
2012-06-27 12:40 ` Laurent Pinchart
2012-06-27 20:06 ` Lars-Peter Clausen
2012-06-27 20:27 ` Laurent Pinchart
2012-06-27 20:56 ` Lars-Peter Clausen [this message]
2012-05-30 16:40 ` Sascha Hauer
2012-05-31 9:42 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEB7379.8040102@metafoo.de \
--to=lars@metafoo.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.