From: Dave Hansen <dave@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>,
linux-mm@kvack.org, mhocko@suse.cz, hannes@cmpxchg.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 3/3] mm/sparse: more check on mem_section number
Date: Wed, 27 Jun 2012 15:14:37 -0700 [thread overview]
Message-ID: <4FEB85CD.4060705@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206271506260.22985@chino.kir.corp.google.com>
On 06/27/2012 03:06 PM, David Rientjes wrote:
>> > + VM_BUG_ON(root_nr >= NR_SECTION_ROOTS);
>> > +
> VM_BUG_ON(root_nr == NR_SECTION_ROOTS);
Whoops, when I suggested >=, I wasn't reading the context. I thought
root_nr was an argument, not a for() loop variable. This isn't exactly
_broken_, but it makes no sense the way the code is now.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-27 22:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 16:36 [PATCH v2 1/3] mm/sparse: optimize sparse_index_alloc Gavin Shan
2012-06-27 16:36 ` [PATCH v2 2/3] mm/sparse: fix possible memory leak Gavin Shan
2012-06-27 17:01 ` Dave Hansen
2012-06-28 6:03 ` Gavin Shan
2012-06-28 14:54 ` Dave Hansen
2012-07-01 13:26 ` Gavin Shan
2012-06-27 22:07 ` David Rientjes
2012-06-28 6:16 ` Gavin Shan
2012-06-28 21:34 ` David Rientjes
2012-07-01 13:41 ` Gavin Shan
2012-06-28 12:57 ` Michal Hocko
2012-06-29 1:22 ` Gavin Shan
2012-06-27 16:36 ` [PATCH v2 3/3] mm/sparse: more check on mem_section number Gavin Shan
2012-06-27 22:06 ` David Rientjes
2012-06-27 22:14 ` Dave Hansen [this message]
2012-06-28 6:18 ` Gavin Shan
2012-06-27 22:10 ` [PATCH v2 1/3] mm/sparse: optimize sparse_index_alloc David Rientjes
2012-06-28 12:52 ` Michal Hocko
2012-06-29 1:20 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEB85CD.4060705@linux.vnet.ibm.com \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.