From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: [PATCH] can: flexcan: use of_property_read_u32 to avoid endian problem Date: Thu, 28 Jun 2012 07:06:16 +0200 Message-ID: <4FEBE648.7040007@hartkopp.net> References: <1340852337-19840-1-git-send-email-jason77.wang@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mo-p00-ob.rzone.de ([81.169.146.160]:24639 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123Ab2F1FGT (ORCPT ); Thu, 28 Jun 2012 01:06:19 -0400 In-Reply-To: Sender: linux-can-owner@vger.kernel.org List-ID: To: Shawn Guo , Hui Wang Cc: mkl@pengutronix.de, wg@grandegger.com, linux-can@vger.kernel.org The first patch (you wanted to superseed) has already been pulled from Dave Miller, see: http://git.kernel.org/?p=linux/kernel/git/davem/net.git;a=commitdiff;h=85f2f834e85517307f13e30e630a5fc86f757cb5 If you want to update your patch you need to do this based on your already accepted patch. Regards, Oliver Btw. no need to put Dave Miller in all your CAN-related postings in CC. He get's hundreds of mails each day ... On 28.06.2012 05:32, Shawn Guo wrote: > On 28 June 2012 10:58, Hui Wang wrote: >> Use of_property_read_u32() to get DT value can avoid endian problems, >> this is needed since this driver can run on powerpc (be) and arm (le). >> >> No need to check ret value here since we will check the got value to >> verify if users pass a valid value in the DT. >> >> Cc: linux-can@vger.kernel.org >> Cc: Marc Kleine-Budde >> Cc: David S. Miller >> Cc: Shawn Guo > > Reviewed-by: Shawn Guo > >> Cc: Wolfgang Grandegger >> Signed-off-by: Hui Wang > -- > To unsubscribe from this list: send the line "unsubscribe linux-can" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html