[PATCH] eeepc-wmi: change wireless key event to toggle all wireless devices.

[PATCH] eeepc-wmi: change wireless key event to toggle all wireless devices.

[Alex Hung]

The original key event from Fn+F2 hotkey only toggles the state of wireless
LAN and leaves other wireless devices such as bluetooth uncontrolled. This
fix change Fn+F2 to generate an event to toggle all wireless devices.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 drivers/platform/x86/eeepc-wmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
index 5568c43..ef361fc 100644
--- a/drivers/platform/x86/eeepc-wmi.c
+++ b/drivers/platform/x86/eeepc-wmi.c
@@ -68,7 +68,7 @@ static const struct key_entry eeepc_wmi_keymap[] = {
 	{ KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
 	{ KE_KEY, 0x32, { KEY_MUTE } },
 	{ KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */
-	{ KE_KEY, 0x5d, { KEY_WLAN } },
+	{ KE_KEY, 0x5d, { KEY_RFKILL } },
 	{ KE_KEY, 0x6b, { KEY_TOUCHPAD_TOGGLE } }, /* Toggle Touchpad */
 	{ KE_KEY, 0x82, { KEY_CAMERA } },
 	{ KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } },
-- 
1.7.0.4

Re: [PATCH] eeepc-wmi: change wireless key event to toggle all wireless devices.

[Alex Hung]

Hi All,

This patch needs to work with another fix in net/rfkill/core.c

http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next.git;a=commit;h=27e49ca95570c4685a32be9d4664f2b0b6d89368

On 06/20/2012 11:26 AM, Alex Hung wrote:
> The original key event from Fn+F2 hotkey only toggles the state of wireless
> LAN and leaves other wireless devices such as bluetooth uncontrolled. This
> fix change Fn+F2 to generate an event to toggle all wireless devices.
>
> Signed-off-by: Alex Hung<alex.hung@canonical.com>
> ---
>   drivers/platform/x86/eeepc-wmi.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c
> index 5568c43..ef361fc 100644
> --- a/drivers/platform/x86/eeepc-wmi.c
> +++ b/drivers/platform/x86/eeepc-wmi.c
> @@ -68,7 +68,7 @@ static const struct key_entry eeepc_wmi_keymap[] = {
>   	{ KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
>   	{ KE_KEY, 0x32, { KEY_MUTE } },
>   	{ KE_KEY, 0x5c, { KEY_F15 } }, /* Power Gear key */
> -	{ KE_KEY, 0x5d, { KEY_WLAN } },
> +	{ KE_KEY, 0x5d, { KEY_RFKILL } },
>   	{ KE_KEY, 0x6b, { KEY_TOUCHPAD_TOGGLE } }, /* Toggle Touchpad */
>   	{ KE_KEY, 0x82, { KEY_CAMERA } },
>   	{ KE_KEY, 0x83, { KEY_CAMERA_ZOOMIN } },

Re: [PATCH] eeepc-wmi: change wireless key event to toggle all wireless devices.

[Matthew Garrett]

Is this the expected behaviour (ie, is this what happens on Windows as 
well)?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] eeepc-wmi: change wireless key event to toggle all wireless devices.

[Alex Hung]

On 06/27/2012 02:33 AM, Matthew Garrett wrote:
> Is this the expected behaviour (ie, is this what happens on Windows as
> well)?
>

Windows has an hotkey application called ATK. When Fn+F2 is pressed, it 
displays options for turning on/off for WLAN and Bluebooth.

ASUS agreed this is better as the previous code only turns off WLAN and 
there is no way to turn off Bluetooth.

Re: [PATCH] eeepc-wmi: change wireless key event to toggle all wireless devices.

[Matthew Garrett]

Ok, I'll merge this.

-- 
Matthew Garrett | mjg59@srcf.ucam.org