From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Jan Kiszka <jan.kiszka@web.de>,
Liu Ping Fan <pingfank@linux.vnet.ibm.com>,
kvm <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop
Date: Thu, 28 Jun 2012 18:12:57 +0300 [thread overview]
Message-ID: <4FEC7479.5000509@redhat.com> (raw)
In-Reply-To: <4FEC65DF.20504@codemonkey.ws>
On 06/28/2012 05:10 PM, Anthony Liguori wrote:
>>
>> 1. read_lock(memmap_lock)
>> 2. MemoryRegionSection mrs = lookup(addr)
>> 3. qom_ref(mrs.mr->dev)
>> 4. read_unlock(memmap_lock)
>>
>> 5. mutex_lock(dev->lock)
>> 6. dispatch(&mrs, addr, data, size)
>> 7. mutex_unlock(dev->lock)
>
> Just a detail, I don't think we should acquire a device specific lock in
> global code. Rather, I think we should acquire the global lock before
> dispatch unless a MemoryRegion is marked as being unlocked.
I think I agree. The mutex acquisition is moved inside dispatch (in
device-specific code). A side effect is that device code must not call
memory_region_destroy() outside its constructor or destructor.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-06-28 15:14 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 22:45 [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop Jan Kiszka
2012-06-22 22:55 ` Jan Kiszka
2012-06-22 22:55 ` [Qemu-devel] " Jan Kiszka
2012-06-23 0:22 ` Marcelo Tosatti
2012-06-23 0:22 ` [Qemu-devel] " Marcelo Tosatti
2012-06-23 9:06 ` Marcelo Tosatti
2012-06-23 9:06 ` [Qemu-devel] " Marcelo Tosatti
2012-06-23 11:45 ` Jan Kiszka
2012-06-23 11:45 ` [Qemu-devel] " Jan Kiszka
2012-06-24 8:49 ` Avi Kivity
2012-06-24 8:49 ` [Qemu-devel] " Avi Kivity
2012-06-24 14:08 ` Jan Kiszka
2012-06-24 14:08 ` Jan Kiszka
2012-06-24 14:31 ` Avi Kivity
2012-06-24 14:31 ` Avi Kivity
2012-07-06 17:16 ` Jan Kiszka
2012-07-06 17:16 ` [Qemu-devel] " Jan Kiszka
2012-07-06 18:06 ` Jan Kiszka
2012-07-06 18:06 ` [Qemu-devel] " Jan Kiszka
2012-07-08 7:49 ` Avi Kivity
2012-07-08 7:49 ` [Qemu-devel] " Avi Kivity
2012-06-24 13:34 ` liu ping fan
2012-06-24 13:34 ` [Qemu-devel] " liu ping fan
2012-06-24 14:08 ` Jan Kiszka
2012-06-24 14:08 ` [Qemu-devel] " Jan Kiszka
2012-06-24 14:35 ` Avi Kivity
2012-06-24 14:35 ` [Qemu-devel] " Avi Kivity
2012-06-24 14:40 ` Jan Kiszka
2012-06-24 14:40 ` [Qemu-devel] " Jan Kiszka
2012-06-24 14:46 ` Avi Kivity
2012-06-24 14:46 ` [Qemu-devel] " Avi Kivity
2012-06-24 14:51 ` Jan Kiszka
2012-06-24 14:51 ` [Qemu-devel] " Jan Kiszka
2012-06-24 14:56 ` Avi Kivity
2012-06-24 14:56 ` [Qemu-devel] " Avi Kivity
2012-06-24 14:58 ` Jan Kiszka
2012-06-24 14:58 ` [Qemu-devel] " Jan Kiszka
2012-06-24 14:59 ` Avi Kivity
2012-06-24 14:59 ` [Qemu-devel] " Avi Kivity
2012-06-23 9:22 ` Jan Kiszka
2012-06-23 9:22 ` [Qemu-devel] " Jan Kiszka
2012-06-28 1:11 ` Marcelo Tosatti
2012-06-26 19:34 ` Marcelo Tosatti
2012-06-27 7:39 ` Stefan Hajnoczi
2012-06-27 7:41 ` [Qemu-devel] " Stefan Hajnoczi
2012-06-27 11:09 ` Marcelo Tosatti
2012-06-27 11:19 ` [Qemu-devel] " Marcelo Tosatti
2012-06-28 8:45 ` Stefan Hajnoczi
2012-06-27 7:54 ` Avi Kivity
2012-06-27 14:36 ` Jan Kiszka
2012-06-28 14:10 ` [Qemu-devel] " Anthony Liguori
2012-06-28 15:12 ` Avi Kivity [this message]
2012-06-29 1:29 ` Marcelo Tosatti
2012-06-29 1:45 ` [Qemu-devel] " Marcelo Tosatti
2012-06-22 22:59 ` Anthony Liguori
2012-06-23 9:11 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEC7479.5000509@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pingfank@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.