All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 3/4] Watchdog exit handling support
Date: Thu, 28 Jun 2012 22:26:43 +0000	[thread overview]
Message-ID: <4FECDA23.1030909@freescale.com> (raw)
In-Reply-To: <1340861999-31281-3-git-send-email-Bharat.Bhushan@freescale.com>

On 06/28/2012 12:39 AM, Bharat Bhushan wrote:
> This patch adds the support to handle the exit caused by watchdog
> (KVM_EXIT_WDT). In the handling we clear the TSR register.

I'm not sure what the logical split is between this patch and 4/4...

> diff --git a/hw/ppc_booke.c b/hw/ppc_booke.c
> index 837a5b6..a9fba15 100644
> --- a/hw/ppc_booke.c
> +++ b/hw/ppc_booke.c
> @@ -203,6 +203,11 @@ static void booke_wdt_cb(void *opaque)
>                               booke_timer->wdt_timer);
>  }
>  
> +void ppc_booke_wdt_clear_tsr(CPUPPCState *env, target_ulong tsr)
> +{
> +    env->spr[SPR_BOOKE_TSR] = tsr & ~(TSR_ENW | TSR_WIS | TSR_WRS_MASK);
> +}
> +

We should probably call this function before returning to KVM, at least
after we halt for debug, possibly other times.

-Scott


  reply	other threads:[~2012-06-28 22:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28  5:51 [PATCH 3/4] Watchdog exit handling support Bharat Bhushan
2012-06-28 22:26 ` Scott Wood [this message]
2012-07-04 11:13 ` Bhushan Bharat-R65777
2012-07-05 20:27 ` Scott Wood
2012-07-06  0:43 ` Bhushan Bharat-R65777
2012-07-06  1:00 ` Scott Wood
2012-07-06  1:16 ` Bhushan Bharat-R65777
2012-07-06  1:18 ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FECDA23.1030909@freescale.com \
    --to=scottwood@freescale.com \
    --cc=kvm-ppc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.